From 3ccf1af916bcf59dd12f05d665b2de9cf7616620 Mon Sep 17 00:00:00 2001
From: schneider <schneider@muc.ccc.de>
Date: Thu, 15 Aug 2019 11:36:24 +0000
Subject: [PATCH] doc(buttons): Add a comment about not using PB_Get
---
epicardium/modules/buttons.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/epicardium/modules/buttons.c b/epicardium/modules/buttons.c
index fb3b10055..965df3199 100644
--- a/epicardium/modules/buttons.c
+++ b/epicardium/modules/buttons.c
@@ -14,6 +14,7 @@ static void epic_buttons_update(uint8_t mask)
button_states[3] = MAX77650_getDebounceStatusnEN0();
}
if (portexpander_detected() && (mask % 8)) {
+ /* Not using PB_Get() here as that performs one I2C transcation per button */
uint8_t button_status = portexpander_get();
for (int i = 0; i < 3; i++) {
button_states[i] = (button_status >> ButtonPin[i]) & 1;
--
GitLab