From e813541e3f8a65fcc6e1b666e6547bd10b3dc316 Mon Sep 17 00:00:00 2001
From: Damien George <damien.p.george@gmail.com>
Date: Fri, 16 Oct 2015 22:08:57 +0100
Subject: [PATCH] py: Add option for inline assembler to support ARMv7-M
instructions.
Cortex-M0, M0+ and M1 only have ARMv6-M Thumb/Thumb2 instructions. M3,
M4 and M7 have a superset of these, named ARMv7-M. This patch adds a
config option to enable support of the superset of instructions.
---
py/emitinlinethumb.c | 31 ++++++++++++++++++++-----------
py/mpconfig.h | 5 +++++
2 files changed, 25 insertions(+), 11 deletions(-)
diff --git a/py/emitinlinethumb.c b/py/emitinlinethumb.c
index 391d05789..fbec0ed0e 100644
--- a/py/emitinlinethumb.c
+++ b/py/emitinlinethumb.c
@@ -392,6 +392,9 @@ STATIC const format_vfp_op_t format_vfp_op_table[] = {
};
#endif
+// shorthand alias for whether we allow ARMv7-M instructions
+#define ARMV7M MICROPY_EMIT_INLINE_THUMB_ARMV7M
+
STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_args, mp_parse_node_t *pn_args) {
// TODO perhaps make two tables:
// one_args =
@@ -527,7 +530,7 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
asm_thumb_op16(emit->as, 0x4700 | (r << 3));
} else if (op_str[0] == 'b' && (op_len == 3
|| (op_len == 5 && op_str[3] == '_'
- && (op_str[4] == 'n' || op_str[4] == 'w')))) {
+ && (op_str[4] == 'n' || (ARMV7M && op_str[4] == 'w'))))) {
mp_uint_t cc = -1;
for (mp_uint_t i = 0; i < MP_ARRAY_SIZE(cc_name_table); i++) {
if (op_str[1] == cc_name_table[i].name[0] && op_str[2] == cc_name_table[i].name[1]) {
@@ -541,7 +544,7 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
if (!asm_thumb_bcc_nw_label(emit->as, cc, label_num, op_len == 5 && op_str[4] == 'w')) {
goto branch_not_in_range;
}
- } else if (op_str[0] == 'i' && op_str[1] == 't') {
+ } else if (ARMV7M && op_str[0] == 'i' && op_str[1] == 't') {
const char *arg_str = get_arg_str(pn_args[0]);
mp_uint_t cc = -1;
for (mp_uint_t i = 0; i < MP_ARRAY_SIZE(cc_name_table); i++) {
@@ -585,6 +588,9 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
if ((reglist & 0xff00) == 0) {
asm_thumb_op16(emit->as, 0xb400 | reglist);
} else {
+ if (!ARMV7M) {
+ goto unknown_op;
+ }
asm_thumb_op32(emit->as, 0xe92d, reglist);
}
} else if (strcmp(op_str, "pop") == 0) {
@@ -592,6 +598,9 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
if ((reglist & 0xff00) == 0) {
asm_thumb_op16(emit->as, 0xbc00 | reglist);
} else {
+ if (!ARMV7M) {
+ goto unknown_op;
+ }
asm_thumb_op32(emit->as, 0xe8bd, reglist);
}
} else {
@@ -606,7 +615,7 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
mp_uint_t reg_dest = get_arg_reg(emit, op_str, pn_args[0], 15);
mp_uint_t reg_src = get_arg_reg(emit, op_str, pn_args[1], 15);
asm_thumb_mov_reg_reg(emit->as, reg_dest, reg_src);
- } else if (strcmp(op_str, "clz") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "clz") == 0) {
op_code_hi = 0xfab0;
op_code = 0xf080;
mp_uint_t rd, rm;
@@ -614,7 +623,7 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
rd = get_arg_reg(emit, op_str, pn_args[0], 15);
rm = get_arg_reg(emit, op_str, pn_args[1], 15);
asm_thumb_op32(emit->as, op_code_hi | rm, op_code | (rd << 8) | rm);
- } else if (strcmp(op_str, "rbit") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "rbit") == 0) {
op_code_hi = 0xfa90;
op_code = 0xf0a0;
goto op_clz_rbit;
@@ -656,24 +665,24 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
} else if (strcmp(op_str, "sub") == 0) {
op_code = ASM_THUMB_FORMAT_3_SUB;
goto op_format_3;
- } else if (strcmp(op_str, "movw") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "movw") == 0) {
op_code = ASM_THUMB_OP_MOVW;
mp_uint_t reg_dest;
op_movw_movt:
reg_dest = get_arg_reg(emit, op_str, pn_args[0], 15);
int i_src = get_arg_i(emit, op_str, pn_args[1], 0xffff);
asm_thumb_mov_reg_i16(emit->as, op_code, reg_dest, i_src);
- } else if (strcmp(op_str, "movt") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "movt") == 0) {
op_code = ASM_THUMB_OP_MOVT;
goto op_movw_movt;
- } else if (strcmp(op_str, "movwt") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "movwt") == 0) {
// this is a convenience instruction
// we clear the MSB since it might be set from extracting the small int value
mp_uint_t reg_dest = get_arg_reg(emit, op_str, pn_args[0], 15);
int i_src = get_arg_i(emit, op_str, pn_args[1], 0xffffffff);
asm_thumb_mov_reg_i16(emit->as, ASM_THUMB_OP_MOVW, reg_dest, i_src & 0xffff);
asm_thumb_mov_reg_i16(emit->as, ASM_THUMB_OP_MOVT, reg_dest, (i_src >> 16) & 0x7fff);
- } else if (strcmp(op_str, "ldrex") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "ldrex") == 0) {
mp_uint_t r_dest = get_arg_reg(emit, op_str, pn_args[0], 15);
mp_parse_node_t pn_base, pn_offset;
if (get_arg_addr(emit, op_str, pn_args[1], &pn_base, &pn_offset)) {
@@ -725,7 +734,7 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
src_b = get_arg_i(emit, op_str, pn_args[2], 0x7);
}
asm_thumb_format_2(emit->as, op_code, rlo_dest, rlo_src, src_b);
- } else if (strcmp(op_str, "sdiv") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "sdiv") == 0) {
op_code = 0xfb90; // sdiv high part
mp_uint_t rd, rn, rm;
op_sdiv_udiv:
@@ -733,13 +742,13 @@ STATIC void emit_inline_thumb_op(emit_inline_asm_t *emit, qstr op, mp_uint_t n_a
rn = get_arg_reg(emit, op_str, pn_args[1], 15);
rm = get_arg_reg(emit, op_str, pn_args[2], 15);
asm_thumb_op32(emit->as, op_code | rn, 0xf0f0 | (rd << 8) | rm);
- } else if (strcmp(op_str, "udiv") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "udiv") == 0) {
op_code = 0xfbb0; // udiv high part
goto op_sdiv_udiv;
} else if (strcmp(op_str, "sub") == 0) {
op_code = ASM_THUMB_FORMAT_2_SUB;
goto op_format_2;
- } else if (strcmp(op_str, "strex") == 0) {
+ } else if (ARMV7M && strcmp(op_str, "strex") == 0) {
mp_uint_t r_dest = get_arg_reg(emit, op_str, pn_args[0], 15);
mp_uint_t r_src = get_arg_reg(emit, op_str, pn_args[1], 15);
mp_parse_node_t pn_base, pn_offset;
diff --git a/py/mpconfig.h b/py/mpconfig.h
index acee5ee95..7ab179304 100644
--- a/py/mpconfig.h
+++ b/py/mpconfig.h
@@ -199,6 +199,11 @@
#define MICROPY_EMIT_INLINE_THUMB (0)
#endif
+// Whether to enable ARMv7-M instruction support in the Thumb2 inline assembler
+#ifndef MICROPY_EMIT_INLINE_THUMB_ARMV7M
+#define MICROPY_EMIT_INLINE_THUMB_ARMV7M (1)
+#endif
+
// Whether to enable float support in the Thumb2 inline assembler
#ifndef MICROPY_EMIT_INLINE_THUMB_FLOAT
#define MICROPY_EMIT_INLINE_THUMB_FLOAT (1)
--
GitLab