From 6dfda96cc4e2dfc7dd4d715f96049ff2a5fcf738 Mon Sep 17 00:00:00 2001 From: Martin/Geno <geno+dev@fireorbit.de> Date: Mon, 26 Aug 2019 10:32:19 +0200 Subject: [PATCH] ble: card10 svc - fix get value of bg leds top --- epicardium/ble/card10.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/epicardium/ble/card10.c b/epicardium/ble/card10.c index 2378244a..c4229582 100644 --- a/epicardium/ble/card10.c +++ b/epicardium/ble/card10.c @@ -380,10 +380,11 @@ static const attsAttr_t card10SvcAttrList[] = { .pValue = ledBGTopRightValue, .pLen = &rgbLen, .maxLen = 3 * sizeof(uint8_t), - .settings = ATTS_SET_WRITE_CBACK, + .settings = (ATTS_SET_WRITE_CBACK | ATTS_SET_READ_CBACK), .permissions = (ATTS_PERMIT_WRITE | ATTS_PERMIT_WRITE_ENC | - ATTS_PERMIT_WRITE_AUTH) }, + ATTS_PERMIT_WRITE_AUTH | ATTS_PERMIT_READ | + ATTS_PERMIT_READ_ENC | ATTS_PERMIT_READ_AUTH) }, // BG LED top left @@ -396,10 +397,11 @@ static const attsAttr_t card10SvcAttrList[] = { .pValue = ledBGTopLeftValue, .pLen = &rgbLen, .maxLen = 3 * sizeof(uint8_t), - .settings = ATTS_SET_WRITE_CBACK, + .settings = (ATTS_SET_WRITE_CBACK | ATTS_SET_READ_CBACK), .permissions = (ATTS_PERMIT_WRITE | ATTS_PERMIT_WRITE_ENC | - ATTS_PERMIT_WRITE_AUTH) }, + ATTS_PERMIT_WRITE_AUTH | ATTS_PERMIT_READ | + ATTS_PERMIT_READ_ENC | ATTS_PERMIT_READ_AUTH) }, // Dim bottom module @@ -554,15 +556,15 @@ static uint8_t setRGBLed(uint8_t led, uint8_t *pValue) */ static uint8_t getRGBLed(uint8_t led, attsAttr_t *pAttr) { - epic_leds_get_rgb(led, pAttr->pValue); - APP_TRACE_INFO4( - "ble-card10: set rgb led %d: #%02x%02x%02x\n", - led, - pAttr->pValue[0], - pAttr->pValue[1], - pAttr->pValue[2] - ); - return ATT_SUCCESS; + epic_leds_get_rgb(led, pAttr->pValue); + APP_TRACE_INFO4( + "ble-card10: set rgb led %d: #%02x%02x%02x\n", + led, + pAttr->pValue[0], + pAttr->pValue[1], + pAttr->pValue[2] + ); + return ATT_SUCCESS; } /* -- GitLab