From e8217c2a9b82f50d4718fd9f02f54c21cb9b512c Mon Sep 17 00:00:00 2001
From: Damien <damien.p.george@gmail.com>
Date: Fri, 1 Nov 2013 23:25:08 +0000
Subject: [PATCH] Remove debugging print for SD card; add comment to
possibly-buggy USB code.
---
stm/lib/stm324x7i_eval_sdio_sd.c | 5 -----
stm/lib/usb_core.c | 4 ++--
stm/lib/usb_dcd_int.c | 2 +-
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/stm/lib/stm324x7i_eval_sdio_sd.c b/stm/lib/stm324x7i_eval_sdio_sd.c
index f63b7bb5d6..f10e0bfa58 100644
--- a/stm/lib/stm324x7i_eval_sdio_sd.c
+++ b/stm/lib/stm324x7i_eval_sdio_sd.c
@@ -414,7 +414,6 @@ SD_Error SD_Init(void)
if (errorstatus != SD_OK)
{
- printf("here1\n");
/*!< CMD Response TimeOut (wait for CMDSENT flag) */
return(errorstatus);
}
@@ -423,7 +422,6 @@ SD_Error SD_Init(void)
if (errorstatus != SD_OK)
{
- printf("here2\n");
/*!< CMD Response TimeOut (wait for CMDSENT flag) */
return(errorstatus);
}
@@ -568,7 +566,6 @@ SD_Error SD_PowerON(void)
SDIO_SendCommand(&SDIO_CmdInitStructure);
errorstatus = CmdError();
- printf("here pwr 1 %d\n", errorstatus);
if (errorstatus != SD_OK)
{
@@ -590,7 +587,6 @@ SD_Error SD_PowerON(void)
SDIO_SendCommand(&SDIO_CmdInitStructure);
errorstatus = CmdResp7Error();
- printf("here pwr 2 %d\n", errorstatus);
if (errorstatus == SD_OK)
{
@@ -616,7 +612,6 @@ SD_Error SD_PowerON(void)
SDIO_CmdInitStructure.SDIO_CPSM = SDIO_CPSM_Enable;
SDIO_SendCommand(&SDIO_CmdInitStructure);
errorstatus = CmdResp1Error(SD_CMD_APP_CMD);
- printf("here pwr 3 %d\n", errorstatus);
/*!< If errorstatus is Command TimeOut, it is a MMC card */
/*!< If errorstatus is SD_OK it is a SD card: SD card 2.0 (voltage range mismatch)
diff --git a/stm/lib/usb_core.c b/stm/lib/usb_core.c
index e257e73dc4..4b28c085f2 100644
--- a/stm/lib/usb_core.c
+++ b/stm/lib/usb_core.c
@@ -1961,7 +1961,7 @@ void USB_OTG_ActiveRemoteWakeup(USB_OTG_CORE_HANDLE *pdev)
if(pdev->cfg.low_power)
{
/* un-gate USB Core clock */
- power.d32 = USB_OTG_READ_REG32(&pdev->regs.PCGCCTL);
+ power.d32 = USB_OTG_READ_REG32(&pdev->regs.PCGCCTL); // dpgeorge: taking the address here might be wrong...
power.b.gatehclk = 0;
power.b.stoppclk = 0;
USB_OTG_WRITE_REG32(pdev->regs.PCGCCTL, power.d32);
@@ -1995,7 +1995,7 @@ void USB_OTG_UngateClock(USB_OTG_CORE_HANDLE *pdev)
if(dsts.b.suspsts == 1)
{
/* un-gate USB Core clock */
- power.d32 = USB_OTG_READ_REG32(&pdev->regs.PCGCCTL);
+ power.d32 = USB_OTG_READ_REG32(&pdev->regs.PCGCCTL); // dpgeorge: taking the address here might be wrong...
power.b.gatehclk = 0;
power.b.stoppclk = 0;
USB_OTG_WRITE_REG32(pdev->regs.PCGCCTL, power.d32);
diff --git a/stm/lib/usb_dcd_int.c b/stm/lib/usb_dcd_int.c
index abdb686c6a..7089f34978 100644
--- a/stm/lib/usb_dcd_int.c
+++ b/stm/lib/usb_dcd_int.c
@@ -352,7 +352,7 @@ static uint32_t DCD_HandleResume_ISR(USB_OTG_CORE_HANDLE *pdev)
if(pdev->cfg.low_power)
{
/* un-gate USB Core clock */
- power.d32 = USB_OTG_READ_REG32(&pdev->regs.PCGCCTL);
+ power.d32 = USB_OTG_READ_REG32(&pdev->regs.PCGCCTL); // dpgeorge: taking the address here might be wrong...
power.b.gatehclk = 0;
power.b.stoppclk = 0;
USB_OTG_WRITE_REG32(pdev->regs.PCGCCTL, power.d32);
--
GitLab