From d18260661da7051bb3fc0df1b4dd85304a2ee7a1 Mon Sep 17 00:00:00 2001
From: Rahix <rahix@rahix.de>
Date: Fri, 22 Nov 2019 21:52:58 +0100
Subject: [PATCH] chore(epicardium-modules): Fix all warnings
Fix all warnings in epicardium/modules.
Signed-off-by: Rahix <rahix@rahix.de>
---
epicardium/modules/bhi.c | 2 +-
epicardium/modules/personal_state.c | 2 +-
epicardium/modules/sleep.c | 3 +--
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/epicardium/modules/bhi.c b/epicardium/modules/bhi.c
index b04d2fd5..4e38306e 100644
--- a/epicardium/modules/bhi.c
+++ b/epicardium/modules/bhi.c
@@ -227,7 +227,7 @@ out_free_i2c:
void epic_bhi160_disable_all_sensors()
{
- for (int i = 0; i < sizeof(bhi160_sensor_active); i++) {
+ for (size_t i = 0; i < sizeof(bhi160_sensor_active); i++) {
if (bhi160_sensor_active[i]) {
epic_bhi160_disable_sensor(i);
}
diff --git a/epicardium/modules/personal_state.c b/epicardium/modules/personal_state.c
index cd6c52c7..e1990f2b 100644
--- a/epicardium/modules/personal_state.c
+++ b/epicardium/modules/personal_state.c
@@ -18,7 +18,7 @@ int personal_state_enabled()
int epic_personal_state_set(uint8_t state, bool persistent)
{
- if (state < STATE_NONE || state > STATE_CAMP)
+ if (state > STATE_CAMP)
return -EINVAL;
led_animation_state = 0;
diff --git a/epicardium/modules/sleep.c b/epicardium/modules/sleep.c
index a87bcb0c..70cc35c5 100644
--- a/epicardium/modules/sleep.c
+++ b/epicardium/modules/sleep.c
@@ -142,8 +142,7 @@ static void gpio_low_power(void)
const unsigned int num_pins =
(sizeof(pins_low_power) / sizeof(gpio_cfg_t));
- int i;
- for (i = 0; i < num_pins; i++) {
+ for (size_t i = 0; i < num_pins; i++) {
GPIO_OutClr(&pins_low_power[i]);
GPIO_Config(&pins_low_power[i]);
}
--
GitLab