From 7d96d5f0898cf0cc2c164f2e2f05497d43edc264 Mon Sep 17 00:00:00 2001 From: Rahix <rahix@rahix.de> Date: Wed, 27 Nov 2019 15:49:23 +0100 Subject: [PATCH] fix(serial): Fix serial_flush_from_isr always yielding By passing `&resched` instead of just `resched`, the internal comparison in FreeRTOS would always evaluate to rescheduling. Curiously, only some GCC versions emit the -Waddress warning for this while others do not ... Signed-off-by: Rahix <rahix@rahix.de> --- epicardium/modules/serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/epicardium/modules/serial.c b/epicardium/modules/serial.c index befca3b5..25dd9184 100644 --- a/epicardium/modules/serial.c +++ b/epicardium/modules/serial.c @@ -161,7 +161,7 @@ static void serial_flush_from_isr(void) taskEXIT_CRITICAL_FROM_ISR(basepri); - portYIELD_FROM_ISR(&resched); + portYIELD_FROM_ISR(resched); } static void serial_flush_from_thread(void) -- GitLab