From feb7a097e4e87ac372f779e035600372a6b2aba2 Mon Sep 17 00:00:00 2001
From: Rahix <rahix@rahix.de>
Date: Mon, 26 Aug 2019 12:52:35 +0200
Subject: [PATCH] fix(display): Don't require locking for backlight
Signed-off-by: Rahix <rahix@rahix.de>
---
epicardium/epicardium.h | 8 ++++----
epicardium/modules/display.c | 6 +-----
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/epicardium/epicardium.h b/epicardium/epicardium.h
index ff910c39..2ec722b9 100644
--- a/epicardium/epicardium.h
+++ b/epicardium/epicardium.h
@@ -1352,12 +1352,12 @@ API(API_DISP_FRAMEBUFFER, int epic_disp_framebuffer(union disp_framebuffer *fb))
/**
- * Set the backlight brightness value
+ * Set the backlight brightness.
*
- * :param brightness: brightness from 0 - 100
- * :return: ``0`` on success or negative value in case of an error:
+ * Note that this function does not require acquiring the display.
*
- * - ``-EBUSY``: Display was already locked from another task.
+ * :param brightness: brightness from 0 - 100
+ * :return: ``0`` on success or negative value in case of an error
*/
API(API_DISP_BACKLIGHT, int epic_disp_backlight(uint16_t brightness));
diff --git a/epicardium/modules/display.c b/epicardium/modules/display.c
index c8dc5149..ed8757fb 100644
--- a/epicardium/modules/display.c
+++ b/epicardium/modules/display.c
@@ -173,11 +173,7 @@ int epic_disp_framebuffer(union disp_framebuffer *fb)
int epic_disp_backlight(uint16_t brightness)
{
- int cl = check_lock();
- if (cl < 0) {
- return cl;
- }
-
+ /* TODO: lock? */
LCD_SetBacklight(brightness);
return 0;
}
--
GitLab