Skip to content
Snippets Groups Projects
Commit cc8df6bc authored by schneider's avatar schneider
Browse files

chore(ble): Minor cleanup of printfs, dead code and obsolete comments

parent c860e80b
Branches
Tags
1 merge request!446Initial MicroPython BLE support (GATTS)
...@@ -682,8 +682,6 @@ static void scannerScanReport(dmEvt_t *pMsg) ...@@ -682,8 +682,6 @@ static void scannerScanReport(dmEvt_t *pMsg)
* \return None. * \return None.
*/ */
/*************************************************************************************************/ /*************************************************************************************************/
#define ATT_CONNECTION_OPENED 0x81
#define ATT_CONNECTION_CLOSED 0x82
static void bleProcMsg(bleMsg_t *pMsg) static void bleProcMsg(bleMsg_t *pMsg)
{ {
hciLeConnCmplEvt_t *connOpen; hciLeConnCmplEvt_t *connOpen;
......
...@@ -42,8 +42,6 @@ static uint8_t DynAttsWriteCback( ...@@ -42,8 +42,6 @@ static uint8_t DynAttsWriteCback(
uint8_t *pValue, uint8_t *pValue,
attsAttr_t *pAttr attsAttr_t *pAttr
) { ) {
printf("DynAttsWriteCback %d, %d, %d\n", handle, len, offset);
struct epic_att_write *att_write = WsfBufAlloc(sizeof(*att_write)); struct epic_att_write *att_write = WsfBufAlloc(sizeof(*att_write));
if (att_write) { if (att_write) {
...@@ -93,7 +91,6 @@ int epic_atts_dyn_create_service( ...@@ -93,7 +91,6 @@ int epic_atts_dyn_create_service(
*pSvcHandle = AttsDynCreateGroup(*start_handle, end_handle); *pSvcHandle = AttsDynCreateGroup(*start_handle, end_handle);
dyn_groups[next_dyn_group++] = *pSvcHandle; dyn_groups[next_dyn_group++] = *pSvcHandle;
//AttsDynRegister(pSvcHandle, DynAttsReadCback, DynAttsWriteCback);
AttsDynRegister(*pSvcHandle, NULL, DynAttsWriteCback); AttsDynRegister(*pSvcHandle, NULL, DynAttsWriteCback);
AttsDynAddAttr( AttsDynAddAttr(
...@@ -246,8 +243,6 @@ int epic_ble_atts_handle_value_ntf( ...@@ -246,8 +243,6 @@ int epic_ble_atts_handle_value_ntf(
return -EIO; return -EIO;
} }
// TODO: There is a race condition here. Ideally AttsHandleValueNtf would return an error or
// raise a callback
AttsHandleValueNtf(connId, handle, valueLen, pValue); AttsHandleValueNtf(connId, handle, valueLen, pValue);
return 0; return 0;
} }
...@@ -259,8 +254,6 @@ int epic_ble_atts_handle_value_ind( ...@@ -259,8 +254,6 @@ int epic_ble_atts_handle_value_ind(
return -EIO; return -EIO;
} }
// TODO: There is a race condition here. Ideally AttsHandleValueInd would return an error or
// raise a callback
AttsHandleValueInd(connId, handle, valueLen, pValue); AttsHandleValueInd(connId, handle, valueLen, pValue);
return 0; return 0;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment