Implement Python module for wristband GPIO access
Does what it says on the tin. It will fix #31 (closed)
Merge request reports
Activity
added 3-Module label
assigned to @rahix
added 5 commits
-
614f7bb8...af4587a9 - 3 commits from branch
card10:master
- 99422553 - feat(epicardium): Add (wristband) GPIO module
- e4b753ee - feat(pycardium): Add (wristband) GPIO module
-
614f7bb8...af4587a9 - 3 commits from branch
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by trilader
- Resolved by trilader
- Resolved by rahix
Thank you very much! Very clean code and the Python facing API looks good, too.
The only nagging point I have is error values. Please return errno codes from all functions in case something goes wrong or invalid values are passed in. On the Python side, raise exceptions when such a value is returned. The easiest way is using
int res = epic_foo(); if (res < 0) { mp_raise_OSError(-res); }
but you might want to use
ValueError
instead if an invalid argument was passed in (like a pin number which does not exist).Edited by rahix- Resolved by trilader
added 1 commit
- 25a54a83 - feat(pycardium): Add (wristband) GPIO module
added 6 commits
-
25a54a83...132874f7 - 4 commits from branch
card10:master
- 2fb78caa - feat(epicardium): Add (wristband) GPIO module
- 2dcd065b - feat(pycardium): Add (wristband) GPIO module
-
25a54a83...132874f7 - 4 commits from branch
Please register or sign in to reply