Skip to content
Snippets Groups Projects

feat(fatfs): remember by which core an FD was opened, allow to close all FDs by a certain core

Merged swym requested to merge swym/firmware:fd_ownership into master
All threads resolved!

untested as of right now, but we can and do now close all FDs opened by core1 in hardware_reset(). In a fatfs_detach, we close all just like before.

Whether an FD is owned by core1 is determined via the API_CALL_MAM->call_flag member, since an API call is the only way for obtain an FD at all.

Merge request reports

Merge request pipeline #2940 passed

Merge request pipeline passed for f86585fa

Approval is optional

Merged by rahixrahix 5 years ago (Aug 22, 2019 3:33pm UTC)

Merge details

  • Changes merged into master with 8c2f6b93.
  • Did not delete the source branch.

Pipeline #2944 passed with warnings

Pipeline passed with warnings for 8c2f6b93 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • rahix changed milestone to %v1.4

    changed milestone to %v1.4

  • swym added 21 commits

    added 21 commits

    • f95322b0...76acf664 - 19 commits from branch card10:master
    • e1b34bb2 - feat(fatfs): remember by which core an FD was opened, allow to close all FDs by a certain core
    • e9f87b9e - bugfix: unlock in close_all

    Compare with previous version

  • swym added 2 commits

    added 2 commits

    • 0227a0a2 - feat(fatfs): API to dump status of FD pool
    • 5d16c11c - use RTOS's current task handle to determine which core is locking the FS

    Compare with previous version

  • swym added 1 commit

    added 1 commit

    • 9dac4d5f - use RTOS's current task handle to determine which core is locking the FS

    Compare with previous version

  • rahix
  • swym added 1 commit

    added 1 commit

    Compare with previous version

  • swym added 1 commit

    added 1 commit

    • f86585fa - feat(fatfs): remember by which core an FD was opened, allow to close all FDs by a certain core

    Compare with previous version

  • Looks good to me! Thanks for keeping our codebase clean.

    However, I'm only a bot - so a human will still have to approve this request.

  • rahix resolved all threads

    resolved all threads

  • merged

  • rahix mentioned in commit 8c2f6b93

    mentioned in commit 8c2f6b93

  • Please register or sign in to reply
    Loading