Skip to content
Snippets Groups Projects

select fonts in Display.print

Merged Hinerk requested to merge hinerk/firmware:more_fonts into master

implementing a new epic method epic_disp_print_adv and improving display.print with new font parameter.

epic_disp_print_adv behaves like epic_disp_print but also takes a new key font, which takes a number to select the font. The font name is verbalized using a new typedef enum FontName. The enum names correlate to the fonts under gfx/fonts. On MicroPython side, in the display module constants were defined in order to provide names instead of numbers

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • rahix
  • rahix
  • rahix
  • rahix
  • added 6 - Changes Requested label and removed 6 - Needs Review label

  • Thanks, nice work! I am a little bit wary of the code-size increase that comes with embedding all font-sizes but if it is not too big, this would be a great addition!

  • Hinerk added 2 commits

    added 2 commits

    • c3dd0253 - adjust module help text to match ReST
    • 1fb264c9 - no typedef and fonts to MACRO_CASE

    Compare with previous version

  • Hinerk added 1 commit

    added 1 commit

    Compare with previous version

  • Hinerk added 1 commit

    added 1 commit

    Compare with previous version

  • Hinerk added 1 commit

    added 1 commit

    • 0425c29d - explicit numbering in disp_font_name enum

    Compare with previous version

  • Hinerk added 1 commit

    added 1 commit

    Compare with previous version

  • Hinerk added 1 commit

    added 1 commit

    Compare with previous version

  • Looks good to me! Thanks for keeping our codebase clean.

    However, I'm only a bot - so a human will still have to approve this request.

  • Hinerk resolved all threads

    resolved all threads

  • which changes are still requested? From what I can tell, this should be labeled as needs-review.

  • added 6 - Needs Review label and removed 6 - Changes Requested label

  • dx
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading