add missing parameters when rendering nickname.txt (!222) · Merge requests · card10 / firmware · GitLab

Snippets Groups Projects

Closed Jochen requested to merge joshi/firmware:card10_nickname_fix into master 5 years ago

fixed blank screen when using card10_nickname with nickname.txt by adding missing parameters to function

Activity

Jochen added 1 commit 5 years ago
added 1 commit

d95df665 - add missing parameters when rendering nickname.txt (fix code style)

Compare with previous version
Jochen added 1 commit 5 years ago
added 1 commit

d8189079 - add missing parameters when rendering nickname.txt (fix code style 2)

Compare with previous version
Annoyatron @annoyatron 5 years ago

Guest

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.
L

Lorphos @Lorphos 5 years ago

There is already pull request !216 (closed) that fixes issue #119 (closed)
swym @swym 5 years ago

Maintainer

Also, duplicate of !210 (closed)
rahix @rahix 5 years ago

Owner

Fix is merged in a5c5e87e.
rahix closed 5 years ago

closed

Please register or sign in to reply