Fix up ECG app (!272) · Merge requests · card10 / firmware · GitLab

Snippets Groups Projects

Merged xiretza requested to merge xiretza/firmware:patch-1 into master 5 years ago

All threads resolved!

Make everything a bit more pythonic and readable, as well as flipping the graph upside down so higher values are drawn above instead of below.

Approval is optional

Activity

xiretza added 2 commits 5 years ago
added 2 commits

3bd7fc64 - style(preload): Improve ECG app code quality

87237c1a - fix(preload): Draw ECG graph right side up

Compare with previous version
Annoyatron @annoyatron · 5 years ago

Guest

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.
rahix added 3 - Preload label 5 years ago

added 3 - Preload label
rahix added 6 - Needs Review label 5 years ago

added 6 - Needs Review label
rahix @rahix started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by xiretza
Last reply by xiretza 5 years ago

rahix changed milestone to 5 years ago

changed milestone to %v1.9

xiretza added 2 commits 5 years ago

added 2 commits

a90e087c - style(preload): Improve ECG app code quality
4ffd0dbf - fix(preload): Draw ECG graph right side up

Compare with previous version

xiretza resolved all threads 5 years ago

resolved all threads

rahix added label and removed label 5 years ago

added 6 - Needs Testing label and removed 6 - Needs Review label

rahix @rahix · 5 years ago

Owner

Works for me #33c3

rahix added label and removed label 5 years ago

added 6 - To Be Merged label and removed 6 - Needs Testing label

rahix merged 5 years ago

merged

rahix mentioned in commit 5 years ago

mentioned in commit 622d2145

Please register or sign in to reply