review of analog clock app (!284) · Merge requests · card10 / firmware · GitLab

Snippets Groups Projects

Open Hinerk requested to merge hinerk/firmware:analog_clock into master 5 years ago

1 unresolved thread

remove Time Class since it is not used
remove unused variables from Clock class

Activity

Annoyatron @annoyatron 5 years ago

Guest

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.
rahix added 3 - Preload 6 - Needs Review labels 5 years ago

added 3 - Preload 6 - Needs Review labels
rahix @rahix 5 years ago

Owner

LGTM
rahix added 6 - Needs Testing label and removed 6 - Needs Review label 5 years ago

added 6 - Needs Testing label and removed 6 - Needs Review label
rahix changed milestone to %v1.10 5 years ago

changed milestone to %v1.10
rahix @rahix started a thread on the diff 5 years ago

preload/apps/analog_clock/__init__.py

                 for x in range(self.radius * 2):
                     line = line + (
                         "."
                         # TODO image is unknown! Dead Code

rahix @rahix 5 years ago

Owner

Please rebase your changes on latest master.

rahix added label and removed label 5 years ago

added 6 - Changes Requested label and removed 6 - Needs Testing label

rahix removed milestone 5 years ago

removed milestone

Please register or sign in to reply