Skip to content
Snippets Groups Projects

Refactor BHI160 App

Merged rahix requested to merge rahix/bhi-refactor into master

This MR makes the BHI160 app more pythonic and fixes a few bugs/issues:

  • An exception (including KeyboardInterrupt) will trigger the sensor to be closed again. Otherwise you'd get strange behavior trying to reopen then afterwards.
  • Use simple_menu.button_events() instead of home-cooked solution. This should hopefully make the code more future-proof.
  • Fix overlapping text caused by the font-rendering changes.

Merge request reports

Merge request pipeline #4001 passed

Merge request pipeline passed for 003aa2a0

Approval is optional

Merged by rahixrahix 5 years ago (Sep 22, 2019 9:33am UTC)

Loading

Pipeline #4002 passed

Pipeline passed for 50839184 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor

    TIL about contextlib.ExitStack, that's awesome. I also like the way orange is calculated :D Looks great overall.

  • rahix added 1 commit

    added 1 commit

    • d8f3f55e - refactor(preload/bhi): Make app more pythonic

    Compare with previous version

  • rahix resolved all threads

    resolved all threads

  • rahix added 6 - Needs Testing label and removed 6 - Needs Review label

    added 6 - Needs Testing label and removed 6 - Needs Review label

  • rahix added 1 commit

    added 1 commit

    • f4755f4b - refactor(preload/bhi): Make app more pythonic

    Compare with previous version

  • rahix resolved all threads

    resolved all threads

  • rahix mentioned in issue #168

    mentioned in issue #168

  • rahix added 4 commits

    added 4 commits

    Compare with previous version

  • rahix added 1 commit

    added 1 commit

    • 060471d8 - refactor(preload/bhi): Make app more pythonic

    Compare with previous version

  • rahix assigned to @rahix

    assigned to @rahix

    • Author Owner
      Resolved by rahix

      The MR is ready to be merged, but I will hold off until the I2C race which is triggered by this is fixed (the upstream version also triggers it, but not as quickly).

  • rahix resolved all threads

    resolved all threads

  • rahix mentioned in issue #169

    mentioned in issue #169

    • Resolved by rahix

      I'd merge this after setting the xQueueSend timeout to zero as a quick fix. After all, the stale data from full queues will only hit applications that ignore the data they have explicitly requested, and then it is their own fault anyway.

      No need to block on #169.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading