Fix only configuring portexpander with MXC_ASSERT enabled

When MXC_ASSERT is disabled, the portexpander_config() call is not compiled into the bootloader which leads to the portexpander not being setup correctly and thus neither the screen turns on nor does the button to switch into MSC mode work correctly (bootloader always goes into MSC mode).

Fix this by moving the portexpander_config() call outside the MXC_ASSERT and only keep the return value check inside. Additionally fix the pull-up/pull-down selection in portexpander_config() not being set correctly.

Fixes #171 (closed)

changed milestone to %v1.12

added 1-Bug 3-Bootloader 6 - Needs Testing labels

cc @Woazboat

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

mentioned in issue #171 (closed)

mentioned in merge request !103 (merged)

merged

mentioned in commit fd5ad609