Ofscreen lines

The animation of the simple_menu used in the main menu had the issue that there is a black line visible at the top. This is due the gfx_puts method ignoring lines, where the top pixel of the string is above the top of the screen. As gfx_puts uses gfx_setpixel which in turn ignores pixels outside of the screen, I removed the check in gfx_puts.

I also removed the ranges from the documentation of the individual python functions and added a general documentation about the screen and it's ranges.

Related: https://git.card10.badge.events.ccc.de/card10/firmware/issues/178

You need to change uint32_t to int32_t and uint16_t to int16_t (for x and y) in the following files:

• epicardium/epicardium.h
• pycardium/modules/sys_display.c
• epicardium/modules/display.c

added 1-Bug 3-Module 6 - Changes Requested labels

assigned to @rahix

changed milestone to %v1.12

added 2 commits

• b315f5e2 - Fix ascii art
• 330e5577 - Make x and y signed integers

Compare with previous version

added 1 commit

• 75cdec84 - Fix linting

Compare with previous version

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

added 6 - Needs Testing label and removed 6 - Changes Requested label

Works for me. Thank you very much! :)

resolved all threads

merged

mentioned in commit a9e1b238

This change alone improved the usability of the main menu by 200%. Thanks a lot!