menu ordered by metadata not folder name (!336) · Merge requests · card10 / firmware · GitLab

Snippets Groups Projects

Closed fleur requested to merge fleur/firmware:b-butwasntthisaboutchaos into master 5 years ago

3 unresolved threads

Activity

fleur added 1 commit 5 years ago
added 1 commit

ad7aabc9 - rly for preload stuff too cmon bruh

Compare with previous version
Annoyatron @annoyatron · 5 years ago

Guest

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.
fleur added 1 commit 5 years ago
added 1 commit

5a2f65ba - bleurgh

Compare with previous version
rahix @rahix started a thread on the diff 5 years ago

preload/menu.py

 if __name__ == "__main__":
     try:
         apps = list(enumerate_apps())
         apps = sorted(list(enumerate_apps()), key=lambda b: b.name.lower())

rahix @rahix started a thread on the diff 5 years ago

preload/menu.py

         if f == "main.py":
             yield App("Home", f)
     for app in sorted(os.listdir("/apps")):

rahix @rahix · 5 years ago

Owner

Thanks! One thing I think will happen with this change is the Home entry no longer being the first one ... Not sure how to solve this properly.

rahix added labels 5 years ago

added 1-Bug 3 - Preload labels

rahix assigned to @rahix 5 years ago

assigned to @rahix

rahix changed milestone to 5 years ago

changed milestone to %v1.12

rahix mentioned in merge request !346 (merged) 5 years ago

mentioned in merge request !346 (merged)

rahix @rahix · 5 years ago

Owner

Superseded by !346 (merged) which includes this change. Thanks @fleur!

rahix closed 5 years ago

closed

Please register or sign in to reply