feat(ecg-app): settings menu [MANUAL MERGE]

• settings menu based on simple_menu to set options instead of overloading buttons several times:
  • new option: length of plotted time window
  • new option: log pulse instead of (or additionally to) the full ecg graph
  • new option: sampling rate
• store the settings to persist to next launch
• some cleanup that is desperately needed in this app
  • create folder for output files
  • rename 'histogram' to 'graph' as it is not a histogram
  • approximate timestamp (and cache log filename) to reduce number of time intensive system calls on pulse logging

added 63 commits

• 6bc4752d...c7e40e27 - 61 commits from branch card10:master
• 878e2178 - settings menu for the ecg app
• 11916890 - offer the option to log the pulse in a separate file

Compare with previous version

added 1 commit

• a6d32c99 - some cleanup: fixed pulse logging format, create folder 'ecg_logs' for output files

Compare with previous version

added 1 commit

• c67b1072 - ecg-app: write setting to and load from file to persistent across launches

Compare with previous version

marked the checklist item store the settings to persist to next launch as completed

changed the description

changed the description

marked the checklist item rename 'histogram' to 'graph' as it is not a histogram as completed

added 1 commit

• 0ea68b28 - replace 'histogram' by 'graph' as it is not a histogram

Compare with previous version

changed the description

added 1 commit

• 64f48a54 - fix performance problems with pulse logging (caching time string and...

Compare with previous version

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

A general cleanup of the code (structuring into submodules?) would still be nice but it should not be much worse than before ^^

unmarked as a Work In Progress

should the metadata be updated? there are several authors for this app by now and it is not revision 1 anymore? ^^

added 1 commit

• f30e6851 - change preload app author to 'card10 contributors'

Compare with previous version

I've cherry-picked commit fbeb7766 ("change preload app author to 'card10 contributors'") from this MR so that part is already in. Please rebase on latest master so we don't get merge-conflicts.

What is the state with the rest of the MR?

added 3 - Preload 6 - Needs Review labels

changed milestone to %v1.13

assigned to @rahix

mentioned in commit 68f60676