Skip to content
Snippets Groups Projects

fix(py display): remove unnecessary out-of-bounds checks to allow clipping of draw calls

Merged fuchsi* requested to merge fuchsi/firmware:drawcall_clipping into master

this solution is contrary to !74 (closed) . Closes #53 (closed) and #188 (closed) . Removing these checks in pycardium is fine as gfx_setpixel handles out-of-bounds coordinates just fine, so that (in accordance with the documentation) draw calls are clipped rather than throwing ValueErrors.

Merge request reports

Merge request pipeline #4209 passed

Merge request pipeline passed for 959658ec

Approval is optional

Merged by rahixrahix 5 years ago (Nov 10, 2019 6:40pm UTC)

Merge details

Pipeline #4214 passed

Pipeline passed for 6bf3fd5b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading