Increase warning level & Fix all warnings (!360) · Merge requests · card10 / firmware

Merged rahix requested to merge fix-all-warnings into master 5 years ago

Dec 09, 2019

chore(hw-test): Fix sign-compare warnings · 24985020
rahix authored 5 years ago
```
Signed-off-by: Rahix <rahix@rahix.de>
```
24985020

hack(ble): Temporarily silence a warning · 4107bd22

rahix authored 5 years ago


With the increased warning-level, GCC warns about three unused fields in
`bleSmpCfg`:

    - maxAttemptTimeout: Maximum 'Repeated attempts' timeout in msec
    - attemptDecTimeout: Time msec before attemptExp decreases
    - attemptExp: Exponent to raise attemptTimeout on maxAttempts

These should probably be set to sensible values but to make !360
mergeable, explicitly set them to zero for now.

Signed-off-by: Rahix <rahix@rahix.de>

4107bd22

Dec 06, 2019

chore(config): Fix a sign-compare warning · b0ba0a42
rahix authored 5 years ago
```
Signed-off-by: Rahix <rahix@rahix.de>
```
b0ba0a42

fix(serial): Fix serial_flush_from_isr always yielding · 7d96d5f0

rahix authored 5 years ago

By passing `&resched` instead of just `resched`, the internal comparison
in FreeRTOS would always evaluate to rescheduling. Curiously, only some
GCC versions emit the -Waddress warning for this while others do not ...

Signed-off-by: Rahix <rahix@rahix.de>

7d96d5f0

chore(max30001): Use proper type for constants · 67cb31c6

rahix authored 5 years ago


Fix sign-compare warnings for these constants.

Signed-off-by: Rahix <rahix@rahix.de>

67cb31c6

chore(l0der): Fix sign-compare warnings · 39411101
rahix authored 5 years ago
```
Signed-off-by: Rahix <rahix@rahix.de>
```
39411101

chore(l0der): Convert all sizes to size_t · 638ee993

rahix authored 5 years ago


It does not make sense for the filesize to be given as `int`; it cannot
ever be negative.  Instead, use `size_t` which is unsigned.

Signed-off-by: Rahix <rahix@rahix.de>

638ee993

chore(pycardium-modules): Fix all warnings · 35762f31
rahix authored 5 years ago
```
Fix all warnings in pycardium/modules.

Signed-off-by: Rahix <rahix@rahix.de>
```
35762f31
chore(epicardium-modules): Fix all warnings · d1826066
rahix authored 5 years ago
```
Fix all warnings in epicardium/modules.

Signed-off-by: Rahix <rahix@rahix.de>
```
d1826066

fix(serial): Make length parameter a size_t · 7662de76

rahix authored 5 years ago


Make the length parameter a `size_t` instead of a `intptr_t`.  A signed
value does not make any sense here and just leads to weird behavior if a
negative value is given nonetheless.

See issue card10/firmware#192

Signed-off-by: Rahix <rahix@rahix.de>

7662de76

chore(libcard10): Fix all sign-compare warnings · 351ddaf8
rahix authored 5 years ago
```
Signed-off-by: Rahix <rahix@rahix.de>
```
351ddaf8
chore(gfx): Fix all sign-compare warnings · 309d1292
rahix authored 5 years ago
```
Signed-off-by: Rahix <rahix@rahix.de>
```
309d1292
feat(ci): Treat all warnings as errors in CI builds · e6ae34ca
rahix authored 5 years ago
```
Signed-off-by: Rahix <rahix@rahix.de>
```
e6ae34ca

chore(build): Disable a warning for mpy-cross-wrapper · be1f99f9

rahix authored 5 years ago


Disable the `unused-parameter` warning for the mpy-cross-wrapper to
silence an error about `argc` being unused (which is ok).

Signed-off-by: Rahix <rahix@rahix.de>

be1f99f9

chore(hardware-init): Fix a sign-compare warning · e36620e6
rahix authored 5 years ago
```
Signed-off-by: Rahix <rahix@rahix.de>
```
e36620e6

fix(crc_patch): Silence a deprecation warning · 321a941e

rahix authored 5 years ago


The crc_patch utility displays the following warning:

    bootloader/./crc_patch.py:31: DeprecationWarning: PY_SSIZE_T_CLEAN
        will be required for '#' formats

We cannot fix the offending library so disable the warnings to prevent
unnecessary build-log clutter.

Signed-off-by: Rahix <rahix@rahix.de>

321a941e

chore(card10-board): Fix a sign-compare warning · ec11dd11

rahix authored 5 years ago


Fix the following warning:

    lib/sdk/Libraries/Boards/card10/Source/board.c: In function 'Board_Init':
    lib/sdk/Libraries/Boards/card10/Source/board.c:102:19: warning:
             comparison of integer expressions of different signedness:
             'int' and 'unsigned int' [-Wsign-compare]
      102 |     for (i = 0; i < num_pins; i++) {
          |                   ^

Signed-off-by: Rahix <rahix@rahix.de>

ec11dd11

chore(epicardium-api): Fix sign-compare warnings · 6b140848

rahix authored 5 years ago


Fix all warnings found by `-Wsign-compare` in epicardium/api.

Signed-off-by: Rahix <rahix@rahix.de>

6b140848

build: Increase warning level to 2 · 942658a6

rahix authored 5 years ago


As discussed in card10/firmware!357, we should increase the number of
enabled compiler warnings to catch a lot more silent bugs.  Increase the
meson-global warning level to 2, but excluding the `unused-parameter`
and `old-style-declaration` warnings.  Additionally, disable warnings
for libraries as we cannot fix that code anyway.

Signed-off-by: Rahix <rahix@rahix.de>

942658a6

Increase warning level & Fix all warnings

Merge request reports

Activity