Stable max86150 epicardium API

Hi @rahix,

Could we merge the stable max86150 epicardium API? pycardium part of !359 (merged) is still not stable, but it would be great to go forward by small commits.

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

added 3-Module 6 - Needs Review labels

Hello @arist!

Sorry for keeping you on hold for this long. I've been drowned in non-card10 work since congress so I did not have much time for card10 firmware. I will probably have a bit more time by mid february ... I hope I did not frustrate you too much with the long silence :/

I think it is a good idea to try and introduce this API step by step! Would you mind splitting this changeset into two commits:

1. The update of the vendor library in lib/vendor/Maxim/MAX86150
2. The new epicardium module

This would help keeping vendor-library changes separate from changes in our firmware code. If you need assistance wrestling git to do this, I can provide some help.

---

Regarding authorship of the commits: You probably know best how much of these changes were yours and how much was @jackie's work. Would it be ok for you to attribute @jackie using a Co-authored-by: ... line, similar to what was done in commit f565f3e6 ("feat(panic): Display panic message on the display")? Who is author and who is co-author is for you two to decide ;)

marked as a Work In Progress

added 14 commits

• 5c82747e...0fd6d958 - 10 commits from branch card10:master
• 17debbe4 - fix(max86150): Get samples by small junks
• b7f8d5df - feat(max86150): max86150 epicardium API
• a7d1f72a - Break the get sample loop in case of errors
• 85a09a27 - add config_size

Compare with previous version

added 2 commits

• e48892c6 - fix(max86150): Get samples from FIFO by small junks
• 2c56869e - feat(max86150): max86150 epicardium API

Compare with previous version

unmarked as a Work In Progress

I think you mixed up the commit message for the second commit? Is it really about the FIFO or is it just the replacement of the MAX86150 library with a better version?

added 2 commits

• 9974b984 - fix(max86150): replace Arduino library with a better version
• 98af3166 - feat(max86150): MAX86150 Epicardium API

Compare with previous version

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

resolved all threads

LGTM! @schneider, I am not in a position to test this right now or make a judgement about the driver functionality itself. If you have time, would you mind taking a look (and merging)?

Will try.

@arist do you by chance have some example code?