Skip to content
Snippets Groups Projects

fix(interrupts): Add the callbacks to the list of root pointers

Merged schneider requested to merge schneider/mpy-portstate into master
All threads resolved!

The garbage collector needs to be aware of the callbacks used for interrupts. Otherwise it might collect the objects which represent the callbacks. This can lead to hard to debug issues where the memory location of the callback gets overwritten by something else and the Python interpreter printing warnings like "can not call float object".

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good to me! Thanks for keeping our codebase clean.

    However, I'm only a bot - so a human will still have to approve this request.

  • schneider added 1 commit

    added 1 commit

    • 314a22e5 - fix(interrupts): Add the callbacks to the list of root pointers

    Compare with previous version

  • schneider added 1 commit

    added 1 commit

    • 6eb4c7ab - fix(mpconfig): Remove hard coded value for interrupt numbers

    Compare with previous version

  • schneider resolved all threads

    resolved all threads

  • schneider
  • schneider added 1 commit

    added 1 commit

    • 2afaf931 - fix(mpconfig): Remove hard coded value for interrupt numbers

    Compare with previous version

  • schneider resolved all threads

    resolved all threads

  • merged

  • schneider mentioned in commit bfbc4215

    mentioned in commit bfbc4215

  • Please register or sign in to reply
    Loading