Default main app selector

Allows setting the default app via the main menu.

added 1 commit

• ef13b459 - wip: default main app selector

Compare with previous version

added 1 commit

• f1042eb9 - wip: default main app selector

Compare with previous version

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

Could you please share, what is the goal of the changes? I hope, it could help by review.

Could it help with traceback that could be observed by turning watch off?

Traceback (most recent call last):
  File "menu.py", line 185, in <module>
  File "simple_menu.py", line 359, in run
  File "simple_menu.py", line 352, in run
  File "simple_menu.py", line 262, in draw_menu
  File "display.py", line 68, in clear
OSError: 16

Surely, that is not very important.

Goal is to be able to easily select another file than the default clock as the default application. Also maybe adding more options like "staring" an entry, so it is at the top of the list.

Can you detail how you got that error?

Ok, I see how to trigger that. Putting the card10 to sleep while showing the menu. I'll have a look if that can be fixed. Not critical though, correct.

Reason is that the "going to sleep" menu takes exclusive ownership of the display and the menu tries to refresh the screen once per second.

This is already present in the current menu code. I suggest to simply ignore it for now...

added 7 commits

• f1042eb9...a126e425 - 6 commits from branch master
• 965bea09 - wip: default main app selector

Compare with previous version

Hi!

Looks like a cool feature and from a quick glance, the implementation also makes sense. Before going into the details, would it be ok for you to split this MR into multiple commits so related changes are more closely tied together?

assigned to @rahix

changed milestone to %v1.16

added 8 commits

• c67972e3 - refact(config): Make config parser more robust
• 726f15eb - refact(config): Use iscntrl to trim lines in epic_config_get_string
• b48b5506 - change(config): Ignore case when reading a boolean
• aef66cad - feat(config): Add epic_config_set_string function
• 7172d5ac - feat(config): Add micropython interface the the config file
• 91f0c969 - feat(main.py): Read the default application from the config file
• 7d2514e7 - feat(simple_menu): Add a method to detect a long (>1 second) press
• 2b744900 - feat(menu): Add a sub menu to set the default app via a long press

Compare with previous version

added 5 commits

• ddd034d0 - feat(config): Add epic_config_set_string function
• 850860e5 - feat(config): Add micropython interface the the config file
• c2ef5163 - feat(main.py): Read the default application from the config file
• d20b83f5 - feat(simple_menu): Add a method to detect a long (>1 second) press
• 4f5c636d - feat(menu): Add a sub menu to set the default app via a long press

Compare with previous version

added 5 commits

• 1c94049b - feat(config): Add epic_config_set_string function
• 53cf5a36 - feat(config): Add micropython interface the the config file
• fab599e4 - feat(main.py): Read the default application from the config file
• 03f0e45f - feat(simple_menu): Add a method to detect a long (>1 second) press
• 2a70c97c - feat(menu): Add a sub menu to set the default app via a long press

Compare with previous version

added 4 commits

• 2fcfff13 - feat(config): Add micropython interface the the config file
• d5b7b3f7 - feat(main.py): Read the default application from the config file
• 1887124d - feat(simple_menu): Add a method to detect a long (>1 second) press
• 5f4b1a8e - feat(menu): Add a sub menu to set the default app via a long press

Compare with previous version

Still needs an update of documentation.