BLE fixes 2020-2

Just some minor changes to more rigidly define the pairing requirements and behaviour. A secure implementation still needs https://git.card10.badge.events.ccc.de/card10/firmware/-/issues/74

I've studied the code and come to some conclusions in https://git.card10.badge.events.ccc.de/card10/firmware/-/issues/74#note_7438

It essentially means that a just works pairing is rejected.

See https://www.bluetooth.com/blog/bluetooth-pairing-part-2-key-generation-methods/

Awesome, thanks

@schneider, looks good though I am probably the wrong person to review bluetooth changes ... If you are confident that this won't regress any currently working setups, I'd merge it.

added 3-Epicardium 4-BLE 6 - To Be Merged labels

added 7 commits

• e241cb3e...5d4325cf - 4 commits from branch master
• 1cd09e2b - fix(ble): Actually require a MITM protected connection
• 9ae70996 - fix(ble): Stay bondable even after a pairing happened
• 5ae9e3a2 - hack: write hci layer log file

Compare with previous version

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

resolved all threads

merged

mentioned in commit f0807c24