Bonding dialog

Creates a makeshift interface between epicardium and pycardium to support a bonding dialog.

The dialog displays the confirmation value and shows if the bonding succeeded / failed.

added 4 commits

• 0ec8c09a - feat(interrupts): Function to check if an int is enabled
• 1f34124b - change(ble): Do not allow bonding by default
• 4ce6aada - feat(ble): Allow apps to make the device bondable
• b292cde2 - feat(ble): Update ble app to support pairing

Compare with previous version

I get always a "fail" message regardless on which device I'm accepting first. Nevertheless, my Pixel 2 thinks it's bonded to the card10 afterwards.

Btw. the app could use button labels.

ble.txt

This branch + ble-5.0-1m worked on the first try.

added 12 commits

• b292cde2...45f6d33f - 6 commits from branch master
• 46f45ae7 - refact(ble): Move numeric comparison into our code base
• 2c00a0fb - hack: ble pairing dialog in bluetooth app
• 3e6238bc - feat(interrupts): Function to check if an int is enabled
• af575989 - change(ble): Do not allow bonding by default
• cd1191dd - feat(ble): Allow apps to make the device bondable
• 4a30865c - feat(ble): Update ble app to support pairing

Compare with previous version

added 7 commits

• e8ffa921 - fix(ble): Update advertising data even when it is empty
• 374ca57e - fix(ble): Remove wrong adv timing entry
• 00bb79e1 - fix(ble): Correctly switch between ADV modes
• e8831dbb - chore(ble): Remove unused cordio UI code
• 0dc0bb5c - feat(ble): Add pretty event printing
• 6b00b79a - fix(config): Fix wrong debug print
• c92b96f7 - feat(ble): Better bonding UI

Compare with previous version

added 5 commits

• 9f525372 - chore(ble): Remove unused cordio UI code
• d0ddd94a - feat(ble): Add pretty event printing
• bd8e072d - fix(config): Fix wrong debug print
• 225f2d7d - feat(ble): Better bonding UI
• 9724d1c4 - refact(ble): Simplify bonding storage

Compare with previous version

changed the description

added 3 commits

• c4f06b5a - refact(ble): Simplify bonding storage
• f7070add - fix(ble): Keep advertising in slected mode after connection closes
• 93991bda - fix(ble): Go back to main.py after bonding

Compare with previous version

Still need to figure out if the two advertising sets are correct. The "connectable" set is empty (does not even contain flags). I have the suspicion that iDevices don't like that.

The current values are essentially taken from the "Fit" example of the SDK.

We might want to make them the same (or at least add the flags to the "connectable" set).

Potentially we should use DM_FLAG_LE_LIMITED_DISC for the "discoverable" set and DM_FLAG_LE_GENERAL_DISC for the "connectable".

added 2 commits

• f1597a27 - feat(ble): Decode some more events
• f9b11a01 - feat(ble): Only be discoverble in the BLE dialog

Compare with previous version

added 1 commit

• 8554a70b - feat(ble): Appear as clock, add card10 UUID

Compare with previous version

So the way to do it is to not set DM_FLAG_LE_GENERAL_DISC or DM_FLAG_LE_LIMITED_DISC during normal operation (connectable) and set DM_FLAG_LE_LIMITED_DISC while in the Bluetooth app. This will hide us during normal operation and move to the top of the list when the Bluetooth app is running.

I've added an appearance data type to the advertisement which shows the card10 as a watch. I've also added one of our 128-bit service UUIDs so we don't have to filter for a specific MAC. This might become relevant once we start using other address types.

added 5 commits

• 9b6a8f75 - fix(ble): Keep advertising in slected mode after connection closes
• 4aef9b4c - fix(ble): Go back to main.py after bonding
• 7335e9af - feat(ble): Decode some more events
• 593e5d58 - feat(ble): Only be discoverble in the BLE dialog
• e4c89923 - feat(ble): Appear as clock, add card10 UUID

Compare with previous version

unmarked as a Work In Progress

@rahix @hauke Would be nice if someone from you could have a look. This should improve user "experience" quite a bit.

Still need to cleanup the epicardium and pycardium APIs.

@schneider, will do! Though give me a few days, unfortunately I am quite busy with work this week ...

added 15 commits

• 43d40861 - feat(interrupts): Function to check if an int is enabled
• eaf47ff4 - refact(ble): Move numeric comparison into our code base
• 85627336 - chore(ble): Remove unused cordio UI code
• d60f0461 - feat(ble): pairing dialog in bluetooth app
• ac4f67b7 - fix(ble): Update advertising data even when it is empty
• 86cd7358 - fix(ble): Remove wrong adv timing entry
• cebea1b9 - fix(ble): Correctly switch between ADV modes
• 690473ef - feat(ble): Add pretty event printing
• d408254a - fix(config): Fix wrong debug print
• cfc24847 - feat(ble): Better bonding UI
• 84698f91 - refact(ble): Simplify bonding storage
• 880c23dd - fix(ble): Keep advertising in slected mode after connection closes
• 1c428de2 - fix(ble): Go back to main.py after bonding
• 9f5a015f - feat(ble): Only be discoverble in the BLE dialog
• 3faf5e2f - feat(ble): Appear as generic watch, add card10 UUID to advertisement

Compare with previous version

added 12 commits

• bace0f82 - feat(ble): pairing dialog in bluetooth app
• 93f50e78 - fix(ble): Update advertising data even when it is empty
• 8458ce6e - fix(ble): Remove wrong adv timing entry
• 25626ba3 - fix(ble): Correctly switch between ADV modes
• 1c4e9678 - feat(ble): Add pretty event printing
• b2d78fea - fix(config): Fix wrong debug print
• 7e8f17f0 - feat(ble): Better bonding UI
• e86c7b6e - refact(ble): Simplify bonding storage
• 3d5789af - fix(ble): Keep advertising in slected mode after connection closes
• 0f23df0a - fix(ble): Go back to main.py after bonding
• 8b226993 - feat(ble): Only be discoverble in the BLE dialog
• 7ea488c6 - feat(ble): Appear as generic watch, add card10 UUID to advertisement

Compare with previous version

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

mentioned in merge request !392 (merged)

merged

mentioned in commit c0a3ed9e