issue 22+37, pretty stable, compiles on my machine
will do: move power on delay, let no cycles be wasted. make leds.py nicer. add another way to save power, hierarchy must only be active during data transmittion, after that even led 14 can be switched off when the top leds are still active i think. will adjust initial rgb channel gammas as soon as i get my hands on final hardware
enjoy =D
Merge request reports
Activity
added 1 commit
- 0fff5248 - removed legacy functions from hardware test + minor bugfix
added 3-Module label
Hi @fleur,
amazing work! I just had a play with it and its plenty fun! Also, the
prideleds
modules is great :)I have taken a look at your changes and there are a few things I noticed. I will leave comments next to the relevant lines. Once these are resolved, we can merge the module!
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
- Resolved by rahix
There is one more thing but it is something for which you are absolutely not to blame: Because you touched some files in hw-tests which weren't previously formatted, your changes get drowned in the formatting changes. To fix this once and for all, I pushed some commits to master which format all of those file.
Now, I have to ask you to rebase again but because of my commits this would produce horrible merge-conflicts. To prevent these, you can rebase like this:
$ git fetch origin $ git rebase -X theirs origin/master
This will unconditionally take your version for all changes (which is ok here because you also applied the formatting script).
added 8 commits
-
f8eb2cde...1bb79811 - 4 commits from branch
card10:master
- 219eb2b1 - issue 22+37, pretty stable, compiles on my machine
- bb623f4f - removed legacy functions from hardware test + minor bugfix
- 6f76c14c - formatting fixed
- f3497016 - added docs & cleaned up a bit. couldn't test pycardium docs yet, epicardium looks good.
Toggle commit list-
f8eb2cde...1bb79811 - 4 commits from branch
added 1 commit
- 636e6489 - docs: Update leds docs so they are rendered correctly