Skip to content
Snippets Groups Projects
Select Git revision
  • 4852e09c7914a4d4f2938dddbe155a2075bb2eb3
  • wip-bootstrap default
  • dualcore
  • ch3/leds
  • ch3/time
  • master
6 results

objnamedtuple.c

Blame
  • user avatar
    stijn authored and Damien George committed
    - namedtuple was wrongly using MP_OBJ_QSTR_VALUE instead of mp_obj_str_get_qstr,
    so when passed a non-interned string it would segfault; fix this by using mp_obj_str_get_qstr
    - store the namedtuple field names as qstrs so it is not needed to use mp_obj_str_get_qstr
    everytime the field name has to be accessed. This also slighty increases performance when
    fetching attributes
    6b636738
    History
    objnamedtuple.c 6.62 KiB
    /*
     * This file is part of the Micro Python project, http://micropython.org/
     *
     * The MIT License (MIT)
     *
     * Copyright (c) 2013, 2014 Damien P. George
     * Copyright (c) 2014 Paul Sokolovsky
     *
     * Permission is hereby granted, free of charge, to any person obtaining a copy
     * of this software and associated documentation files (the "Software"), to deal
     * in the Software without restriction, including without limitation the rights
     * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
     * copies of the Software, and to permit persons to whom the Software is
     * furnished to do so, subject to the following conditions:
     *
     * The above copyright notice and this permission notice shall be included in
     * all copies or substantial portions of the Software.
     *
     * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
     * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
     * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
     * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
     * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
     * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
     * THE SOFTWARE.
     */
    
    #include <string.h>
    
    #include "py/nlr.h"
    #include "py/objtuple.h"
    #include "py/runtime.h"
    
    #if MICROPY_PY_COLLECTIONS
    
    typedef struct _mp_obj_namedtuple_type_t {
        mp_obj_type_t base;
        mp_uint_t n_fields;
        qstr fields[];
    } mp_obj_namedtuple_type_t;
    
    typedef struct _mp_obj_namedtuple_t {
        mp_obj_tuple_t tuple;
    } mp_obj_namedtuple_t;
    
    STATIC mp_uint_t namedtuple_find_field(mp_obj_namedtuple_type_t *type, qstr name) {
        for (mp_uint_t i = 0; i < type->n_fields; i++) {
            if (type->fields[i] == name) {
                return i;
            }
        }
        return -1;
    }
    
    STATIC void namedtuple_print(void (*print)(void *env, const char *fmt, ...), void *env, mp_obj_t o_in, mp_print_kind_t kind) {
        (void)kind;
        mp_obj_namedtuple_t *o = o_in;
        print(env, "%s(", qstr_str(o->tuple.base.type->name));
        const qstr *fields = ((mp_obj_namedtuple_type_t*)o->tuple.base.type)->fields;
        for (mp_uint_t i = 0; i < o->tuple.len; i++) {
            if (i > 0) {
                print(env, ", ");
            }
            print(env, "%s=", qstr_str(fields[i]));
            mp_obj_print_helper(print, env, o->tuple.items[i], PRINT_REPR);
        }
        print(env, ")");
    }
    
    STATIC void namedtuple_load_attr(mp_obj_t self_in, qstr attr, mp_obj_t *dest) {
        mp_obj_namedtuple_t *self = self_in;
        int id = namedtuple_find_field((mp_obj_namedtuple_type_t*)self->tuple.base.type, attr);
        if (id == -1) {
            return;
        }
        dest[0] = self->tuple.items[id];
    }
    
    STATIC bool namedtuple_store_attr(mp_obj_t self_in, qstr attr, mp_obj_t value) {
        (void)self_in;
        (void)attr;
        (void)value;
        nlr_raise(mp_obj_new_exception_msg(&mp_type_AttributeError, "can't set attribute"));
    }
    
    STATIC mp_obj_t namedtuple_make_new(mp_obj_t type_in, mp_uint_t n_args, mp_uint_t n_kw, const mp_obj_t *args) {
        mp_obj_namedtuple_type_t *type = type_in;
        mp_uint_t num_fields = type->n_fields;
        if (n_args + n_kw != num_fields) {
            if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_TERSE) {
                mp_arg_error_terse_mismatch();
            } else if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_NORMAL) {
                nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_TypeError,
                    "function takes %d positional arguments but %d were given",
                    num_fields, n_args + n_kw));
            } else if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_DETAILED) {
                nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_TypeError,
                    "%s() takes %d positional arguments but %d were given",
                    qstr_str(type->base.name), num_fields, n_args + n_kw));
            }
        }
    
        mp_obj_t *arg_objects;
        if (n_args == num_fields) {
            arg_objects = (mp_obj_t*)args;
        } else {
            size_t alloc_size = sizeof(mp_obj_t) * num_fields;
            arg_objects = alloca(alloc_size);
            memset(arg_objects, 0, alloc_size);
    
            for (mp_uint_t i = 0; i < n_args; i++) {
                arg_objects[i] = args[i];
            }
    
            for (mp_uint_t i = n_args; i < n_args + 2 * n_kw; i += 2) {
                qstr kw = mp_obj_str_get_qstr(args[i]);
                int id = namedtuple_find_field(type, kw);
                if (id == -1) {
                    if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_TERSE) {
                        mp_arg_error_terse_mismatch();
                    } else {
                        nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_TypeError,
                            "unexpected keyword argument '%s'",
                            qstr_str(kw)));
                    }
                }
                if (arg_objects[id] != NULL) {
                    if (MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_TERSE) {
                        mp_arg_error_terse_mismatch();
                    } else {
                        nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_TypeError,
                            "function got multiple values for argument '%s'",
                            qstr_str(kw)));
                    }
                }
                arg_objects[id] = args[i + 1];
            }
        }
    
        mp_obj_tuple_t *tuple = mp_obj_new_tuple(num_fields, arg_objects);
        tuple->base.type = type_in;
        return tuple;
    }
    
    STATIC const mp_obj_tuple_t namedtuple_base_tuple = {{&mp_type_tuple}, 1, {(mp_obj_t)&mp_type_tuple}};
    
    STATIC mp_obj_t mp_obj_new_namedtuple_type(qstr name, mp_uint_t n_fields, mp_obj_t *fields) {
        mp_obj_namedtuple_type_t *o = m_new_obj_var(mp_obj_namedtuple_type_t, qstr, n_fields);
        memset(&o->base, 0, sizeof(o->base));
        o->base.base.type = &mp_type_type;
        o->base.name = name;
        o->base.print = namedtuple_print;
        o->base.make_new = namedtuple_make_new;
        o->base.unary_op = mp_obj_tuple_unary_op;
        o->base.binary_op = mp_obj_tuple_binary_op;
        o->base.load_attr = namedtuple_load_attr;
        o->base.store_attr = namedtuple_store_attr;
        o->base.subscr = mp_obj_tuple_subscr;
        o->base.getiter = mp_obj_tuple_getiter;
        o->base.bases_tuple = (mp_obj_t)&namedtuple_base_tuple;
        o->n_fields = n_fields;
        for (mp_uint_t i = 0; i < n_fields; i++) {
            o->fields[i] = mp_obj_str_get_qstr(fields[i]);
        }
        return o;
    }
    
    STATIC mp_obj_t new_namedtuple_type(mp_obj_t name_in, mp_obj_t fields_in) {
        qstr name = mp_obj_str_get_qstr(name_in);
        mp_uint_t n_fields;
        mp_obj_t *fields;
        mp_obj_list_get(fields_in, &n_fields, &fields);
        return mp_obj_new_namedtuple_type(name, n_fields, fields);
    }
    MP_DEFINE_CONST_FUN_OBJ_2(mp_namedtuple_obj, new_namedtuple_type);
    
    #endif // MICROPY_PY_COLLECTIONS