Skip to content
Snippets Groups Projects
Select Git revision
  • dualcore
  • ch3/leds
  • wip-bootstrap default
  • ch3/time
  • master
5 results

run-tests

Blame
    • Damien George's avatar
      96fd80db
      py/objexcept: Prevent infinite recursion when allocating exceptions. · 96fd80db
      Damien George authored
      The aim of this patch is to rewrite the functions that create exception
      instances (mp_obj_exception_make_new and mp_obj_new_exception_msg_varg) so
      that they do not call any functions that may raise an exception.  Otherwise
      it's possible to create infinite recursion with an exception being raised
      while trying to create an exception object.
      
      The two main things that are done to accomplish this are:
      1. Change mp_obj_new_exception_msg_varg to just format the string, then
         call mp_obj_exception_make_new to actually create the exception object.
      2. In mp_obj_exception_make_new and mp_obj_new_exception_msg_varg try to
         allocate all memory first using functions that don't raise exceptions
         If any of the memory allocations fail (return NULL) then degrade
         gracefully by trying other options for memory allocation, eg using the
         emergency exception buffer.
      3. Use a custom printer backend to conservatively format strings: if it
         can't allocate memory then it just truncates the string.
      
      As part of this rewrite, raising an exception without a message, like
      KeyError(123), will now use the emergency buffer to store the arg and
      traceback data if there is no heap memory available.
      
      Memory use with this patch is unchanged.  Code size is increased by:
      
         bare-arm:  +136
      minimal x86:  +124
         unix x64:   +72
      unix nanbox:   +96
            stm32:   +88
          esp8266:   +92
           cc3200:   +80
      96fd80db
      History
      py/objexcept: Prevent infinite recursion when allocating exceptions.
      Damien George authored
      The aim of this patch is to rewrite the functions that create exception
      instances (mp_obj_exception_make_new and mp_obj_new_exception_msg_varg) so
      that they do not call any functions that may raise an exception.  Otherwise
      it's possible to create infinite recursion with an exception being raised
      while trying to create an exception object.
      
      The two main things that are done to accomplish this are:
      1. Change mp_obj_new_exception_msg_varg to just format the string, then
         call mp_obj_exception_make_new to actually create the exception object.
      2. In mp_obj_exception_make_new and mp_obj_new_exception_msg_varg try to
         allocate all memory first using functions that don't raise exceptions
         If any of the memory allocations fail (return NULL) then degrade
         gracefully by trying other options for memory allocation, eg using the
         emergency exception buffer.
      3. Use a custom printer backend to conservatively format strings: if it
         can't allocate memory then it just truncates the string.
      
      As part of this rewrite, raising an exception without a message, like
      KeyError(123), will now use the emergency buffer to store the arg and
      traceback data if there is no heap memory available.
      
      Memory use with this patch is unchanged.  Code size is increased by:
      
         bare-arm:  +136
      minimal x86:  +124
         unix x64:   +72
      unix nanbox:   +96
            stm32:   +88
          esp8266:   +92
           cc3200:   +80