Skip to content
Snippets Groups Projects
cortex_m3.c 47.4 KiB
Newer Older
  • Learn to ignore specific revisions
  • /***************************************************************************
     *   Copyright (C) 2005 by Dominic Rath                                    *
     *   Dominic.Rath@gmx.de                                                   *
    
    oharboe's avatar
    oharboe committed
     *                                                                         *
    
     *   Copyright (C) 2006 by Magnus Lundin                                   *
     *   lundin@mlu.mine.nu                                                    *
     *                                                                         *
    
     *   Copyright (C) 2008 by Spencer Oliver                                  *
     *   spen@spen-soft.co.uk                                                  *
     *                                                                         *
    
     *   This program is free software; you can redistribute it and/or modify  *
     *   it under the terms of the GNU General Public License as published by  *
     *   the Free Software Foundation; either version 2 of the License, or     *
     *   (at your option) any later version.                                   *
     *                                                                         *
     *   This program is distributed in the hope that it will be useful,       *
     *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
     *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
     *   GNU General Public License for more details.                          *
     *                                                                         *
     *   You should have received a copy of the GNU General Public License     *
     *   along with this program; if not, write to the                         *
     *   Free Software Foundation, Inc.,                                       *
     *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
    
     *                                                                         *
     *                                                                         *
     *   Cortex-M3(tm) TRM, ARM DDI 0337C                                      *
     *                                                                         *
    
     ***************************************************************************/
    #ifdef HAVE_CONFIG_H
    #include "config.h"
    #endif
    
    #include "replacements.h"
    
    #include "cortex_m3.h"
    
    #include "armv7m.h"
    
    
    #include "register.h"
    #include "target.h"
    
    #include "target_request.h"
    
    #include "log.h"
    #include "jtag.h"
    #include "arm_jtag.h"
    
    #include <stdlib.h>
    #include <string.h>
    
    /* cli handling */
    int cortex_m3_register_commands(struct command_context_s *cmd_ctx);
    
    ntfreak's avatar
    ntfreak committed
    int handle_cortex_m3_mask_interrupts_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc);
    
    
    /* forward declarations */
    void cortex_m3_enable_breakpoints(struct target_s *target);
    void cortex_m3_enable_watchpoints(struct target_s *target);
    
    int cortex_m3_target_create(struct target_s *target, Jim_Interp *interp);
    
    int cortex_m3_init_target(struct command_context_s *cmd_ctx, struct target_s *target);
    
    oharboe's avatar
    oharboe committed
    int cortex_m3_quit(void);
    
    int cortex_m3_load_core_reg_u32(target_t *target, enum armv7m_regtype type, u32 num, u32 *value);
    int cortex_m3_store_core_reg_u32(target_t *target, enum armv7m_regtype type, u32 num, u32 value);
    
    int cortex_m3_target_request_data(target_t *target, u32 size, u8 *buffer);
    
    int cortex_m3_examine(struct target_s *target);
    
    #ifdef ARMV7_GDB_HACKS
    extern u8 armv7m_gdb_dummy_cpsr_value[];
    extern reg_t armv7m_gdb_dummy_cpsr_reg;
    #endif
    
    
    target_type_t cortexm3_target =
    {
    	.name = "cortex_m3",
    
    	.poll = cortex_m3_poll,
    	.arch_state = armv7m_arch_state,
    
    
    	.target_request_data = cortex_m3_target_request_data,
    	
    
    	.halt = cortex_m3_halt,
    	.resume = cortex_m3_resume,
    	.step = cortex_m3_step,
    
    	.assert_reset = cortex_m3_assert_reset,
    	.deassert_reset = cortex_m3_deassert_reset,
    	.soft_reset_halt = cortex_m3_soft_reset_halt,
    
    	.get_gdb_reg_list = armv7m_get_gdb_reg_list,
    
    	.read_memory = cortex_m3_read_memory,
    	.write_memory = cortex_m3_write_memory,
    	.bulk_write_memory = cortex_m3_bulk_write_memory,
    
    ntfreak's avatar
    ntfreak committed
    	.checksum_memory = armv7m_checksum_memory,
    
    	.blank_check_memory = armv7m_blank_check_memory,
    
    ntfreak's avatar
    ntfreak committed
    	
    
    	.run_algorithm = armv7m_run_algorithm,
    	
    	.add_breakpoint = cortex_m3_add_breakpoint,
    	.remove_breakpoint = cortex_m3_remove_breakpoint,
    	.add_watchpoint = cortex_m3_add_watchpoint,
    	.remove_watchpoint = cortex_m3_remove_watchpoint,
    
    	.register_commands = cortex_m3_register_commands,
    
    	.target_create = cortex_m3_target_create,
    
    	.init_target = cortex_m3_init_target,
    
    	.examine = cortex_m3_examine,
    
    int cortexm3_dap_read_coreregister_u32(swjdp_common_t *swjdp, u32 *value, int regnum)
    {
    	int retval;
    	u32 dcrdr;
    
    	/* because the DCB_DCRDR is used for the emulated dcc channel
    	 * we gave to save/restore the DCB_DCRDR when used */
    
    	mem_ap_read_u32(swjdp, DCB_DCRDR, &dcrdr);
    
    	swjdp->trans_mode = TRANS_MODE_COMPOSITE;
    
    	/* mem_ap_write_u32(swjdp, DCB_DCRSR, regnum); */
    	dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRSR & 0xFFFFFFF0);
    	dap_ap_write_reg_u32(swjdp, AP_REG_BD0 | (DCB_DCRSR & 0xC), regnum );
    
    	/* mem_ap_read_u32(swjdp, DCB_DCRDR, value); */
    	dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRDR & 0xFFFFFFF0);
    	dap_ap_read_reg_u32(swjdp, AP_REG_BD0 | (DCB_DCRDR & 0xC), value );
    
    	mem_ap_write_u32(swjdp, DCB_DCRDR, dcrdr);
    	retval = swjdp_transaction_endcheck(swjdp);
    	return retval;
    }
    
    int cortexm3_dap_write_coreregister_u32(swjdp_common_t *swjdp, u32 value, int regnum)
    {
    	int retval;
    	u32 dcrdr;
    
    	/* because the DCB_DCRDR is used for the emulated dcc channel
    	 * we gave to save/restore the DCB_DCRDR when used */
    
    	mem_ap_read_u32(swjdp, DCB_DCRDR, &dcrdr);
    
    	swjdp->trans_mode = TRANS_MODE_COMPOSITE;
    
    	/* mem_ap_write_u32(swjdp, DCB_DCRDR, core_regs[i]); */
    	dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRDR & 0xFFFFFFF0);
    	dap_ap_write_reg_u32(swjdp, AP_REG_BD0 | (DCB_DCRDR & 0xC), value );
    
    	/* mem_ap_write_u32(swjdp, DCB_DCRSR, i | DCRSR_WnR	); */
    	dap_setup_accessport(swjdp, CSW_32BIT | CSW_ADDRINC_OFF, DCB_DCRSR & 0xFFFFFFF0);
    	dap_ap_write_reg_u32(swjdp, AP_REG_BD0 | (DCB_DCRSR & 0xC), regnum | DCRSR_WnR );
    
    	mem_ap_write_u32(swjdp, DCB_DCRDR, dcrdr);
    	retval = swjdp_transaction_endcheck(swjdp);
    	return retval;
    }
    
    
    
    int cortex_m3_write_debug_halt_mask(target_t *target, u32 mask_on, u32 mask_off)
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	
    	/* mask off status bits */
    	cortex_m3->dcb_dhcsr &= ~((0xFFFF << 16) | mask_off);
    	/* create new register mask */
    	cortex_m3->dcb_dhcsr |= DBGKEY | C_DEBUGEN | mask_on;
    	
    
    	return mem_ap_write_atomic_u32(swjdp, DCB_DHCSR, cortex_m3->dcb_dhcsr);
    
    int cortex_m3_clear_halt(target_t *target)
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	/* clear step if any */
    	cortex_m3_write_debug_halt_mask(target, C_HALT, C_STEP);
    	
    
    	/* Read Debug Fault Status Register */
    
    	mem_ap_read_atomic_u32(swjdp, NVIC_DFSR, &cortex_m3->nvic_dfsr);
    
    	/* Write Debug Fault Status Register to enable processing to resume ?? Try with and without this !! */
    
    	mem_ap_write_atomic_u32(swjdp, NVIC_DFSR, cortex_m3->nvic_dfsr);
    
    	LOG_DEBUG(" NVIC_DFSR 0x%x", cortex_m3->nvic_dfsr);
    
    	return ERROR_OK;
    
    }
    
    int cortex_m3_single_step_core(target_t *target)
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	u32 dhcsr_save;
    	
    	/* backup dhcsr reg */
    	dhcsr_save = cortex_m3->dcb_dhcsr;
    	
    	/* mask interrupts if not done already */
    
    	if (!(cortex_m3->dcb_dhcsr & C_MASKINTS))
    
    		mem_ap_write_atomic_u32(swjdp, DCB_DHCSR, DBGKEY | C_MASKINTS | C_HALT | C_DEBUGEN);
    	mem_ap_write_atomic_u32(swjdp, DCB_DHCSR, DBGKEY | C_MASKINTS | C_STEP | C_DEBUGEN);
    
    	
    	/* restore dhcsr reg */
    	cortex_m3->dcb_dhcsr = dhcsr_save;	
    
    	cortex_m3_clear_halt(target);
    	
    	return ERROR_OK;
    }
    
    int cortex_m3_exec_opcode(target_t *target,u32 opcode, int len /* MODE, r0_invalue, &r0_outvalue */ )
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	mem_ap_read_u32(swjdp, 0x20000000, &savedram);
    	mem_ap_write_u32(swjdp, 0x20000000, opcode);
    	cortexm3_dap_write_coreregister_u32(swjdp, 0x20000000, 15);
    
    	cortex_m3_single_step_core(target);
    
    	armv7m->core_cache->reg_list[15].dirty = armv7m->core_cache->reg_list[15].valid;
    
    	retvalue = mem_ap_write_atomic_u32(swjdp, 0x20000000, savedram);
    
    /* Enable interrupts */
    int cortex_m3_cpsie(target_t *target, u32 IF)
    {
    	return cortex_m3_exec_opcode(target, ARMV7M_T_CPSIE(IF), 2);
    }
    
    /* Disable interrupts */
    int cortex_m3_cpsid(target_t *target, u32 IF)
    {
    	return cortex_m3_exec_opcode(target, ARMV7M_T_CPSID(IF), 2);
    }
    
    
    int cortex_m3_endreset_event(target_t *target)
    {
    	int i;
    
    	u32 dcb_demcr;
    
    	
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	cortex_m3_fp_comparator_t *fp_list = cortex_m3->fp_comparator_list; 
    
    	cortex_m3_dwt_comparator_t *dwt_list = cortex_m3->dwt_comparator_list;
    
    	mem_ap_read_atomic_u32(swjdp, DCB_DEMCR, &dcb_demcr);
    
    	LOG_DEBUG("DCB_DEMCR = 0x%8.8x",dcb_demcr);
    
    	/* this regsiter is used for emulated dcc channel */
    
    	mem_ap_write_u32(swjdp, DCB_DCRDR, 0);
    
    	mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &cortex_m3->dcb_dhcsr);
    
    	if (!(cortex_m3->dcb_dhcsr & C_DEBUGEN))
    
    		mem_ap_write_u32(swjdp, DCB_DHCSR, DBGKEY | C_DEBUGEN);
    
    	
    	/* clear any interrupt masking */
    	cortex_m3_write_debug_halt_mask(target, 0, C_MASKINTS);
    	
    
    	mem_ap_write_u32(swjdp, DCB_DEMCR, TRCENA | VC_HARDERR | VC_BUSERR);
    
    	mem_ap_write_u32(swjdp, NVIC_SHCSR, SHCSR_BUSFAULTENA);
    
    
    	/* Enable FPB */
    	target_write_u32(target, FP_CTRL, 3);
    
    	cortex_m3->fpb_enabled = 1;
    
    	for (i = 0; i < cortex_m3->fp_num_code + cortex_m3->fp_num_lit; i++)
    
    	{
    		target_write_u32(target, fp_list[i].fpcr_address, fp_list[i].fpcr_value);
    	}
    	
    	/* Restore DWT registers */
    
    	for (i = 0; i < cortex_m3->dwt_num_comp; i++)
    
    	{
    		target_write_u32(target, dwt_list[i].dwt_comparator_address, dwt_list[i].comp);
    
    		target_write_u32(target, dwt_list[i].dwt_comparator_address | 0x4, dwt_list[i].mask);
    		target_write_u32(target, dwt_list[i].dwt_comparator_address | 0x8, dwt_list[i].function);
    
    	swjdp_transaction_endcheck(swjdp);
    
    	
    	/* make sure we have latest dhcsr flags */
    
    	mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &cortex_m3->dcb_dhcsr);
    
    	return ERROR_OK;
    }
    
    int cortex_m3_examine_debug_reason(target_t *target)
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    
    	/* THIS IS NOT GOOD, TODO - better logic for detection of debug state reason */
    
    	/* only check the debug reason if we don't know it already */
    	
    	if ((target->debug_reason != DBG_REASON_DBGRQ)
    
    		&& (target->debug_reason != DBG_REASON_SINGLESTEP))
    
    		if (cortex_m3->nvic_dfsr & DFSR_BKPT)
    
    		{
    			target->debug_reason = DBG_REASON_BREAKPOINT;
    
    			if (cortex_m3->nvic_dfsr & DFSR_DWTTRAP)
    
    				target->debug_reason = DBG_REASON_WPTANDBKPT;
    		}
    
    		else if (cortex_m3->nvic_dfsr & DFSR_DWTTRAP)
    
    			target->debug_reason = DBG_REASON_WATCHPOINT;
    	}
    
    	return ERROR_OK;
    }
    
    int cortex_m3_examine_exception_reason(target_t *target)
    {
    
    	u32 shcsr, except_sr, cfsr = -1, except_ar = -1;
    
    
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	mem_ap_read_u32(swjdp, NVIC_SHCSR, &shcsr);
    
    	switch (armv7m->exception_number)
    	{
    		case 2:	/* NMI */
    			break;
    		case 3:	/* Hard Fault */
    
    			mem_ap_read_atomic_u32(swjdp, NVIC_HFSR, &except_sr);
    
    			if (except_sr & 0x40000000)
    
    				mem_ap_read_u32(swjdp, NVIC_CFSR, &cfsr);
    
    			mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr);
    			mem_ap_read_u32(swjdp, NVIC_MMFAR, &except_ar);		
    
    			mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr);
    			mem_ap_read_u32(swjdp, NVIC_BFAR, &except_ar);				
    
    			mem_ap_read_u32(swjdp, NVIC_CFSR, &except_sr);
    
    			break;
    		case 11:	/* SVCall */
    			break;
    		case 12:	/* Debug Monitor */
    
    			mem_ap_read_u32(swjdp, NVIC_DFSR, &except_sr);
    
    			break;
    		case 14:	/* PendSV */
    			break;
    		case 15:	/* SysTick */
    			break;
    		default:
    			except_sr = 0;
    			break;
    	}
    	swjdp_transaction_endcheck(swjdp);
    
    	LOG_DEBUG("%s SHCSR 0x%x, SR 0x%x, CFSR 0x%x, AR 0x%x", armv7m_exception_string(armv7m->exception_number), \
    		shcsr, except_sr, cfsr, except_ar);
    
    	return ERROR_OK;
    }
    
    int cortex_m3_debug_entry(target_t *target)
    {
    
    	u32 xPSR;
    	int retval;
    
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	if (armv7m->pre_debug_entry)
    		armv7m->pre_debug_entry(target);
    
    	cortex_m3_clear_halt(target);
    
    	mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &cortex_m3->dcb_dhcsr);
    
    
    	if ((retval = armv7m->examine_debug_reason(target)) != ERROR_OK)
    		return retval;
    
    	/* Examine target state and mode */
    
    	/* First load register acessible through core debug port*/
    
    	for (i = 0; i < ARMV7M_PRIMASK; i++)
    	{
    		if (!armv7m->core_cache->reg_list[i].valid)
    
    			armv7m->read_core_reg(target, i);
    
    	}
    
    	xPSR = buf_get_u32(armv7m->core_cache->reg_list[ARMV7M_xPSR].value, 0, 32);
    
    
    #ifdef ARMV7_GDB_HACKS
    	/* copy real xpsr reg for gdb, setting thumb bit */
    	buf_set_u32(armv7m_gdb_dummy_cpsr_value, 0, 32, xPSR);
    	buf_set_u32(armv7m_gdb_dummy_cpsr_value, 5, 1, 1);
    	armv7m_gdb_dummy_cpsr_reg.valid = armv7m->core_cache->reg_list[ARMV7M_xPSR].valid;
    	armv7m_gdb_dummy_cpsr_reg.dirty = armv7m->core_cache->reg_list[ARMV7M_xPSR].dirty;
    #endif
    
    
    	/* For IT instructions xPSR must be reloaded on resume and clear on debug exec */
    
    	if (xPSR & 0xf00)
    
    		armv7m->core_cache->reg_list[ARMV7M_xPSR].dirty = armv7m->core_cache->reg_list[ARMV7M_xPSR].valid;
    
    		cortex_m3_store_core_reg_u32(target, ARMV7M_REGISTER_CORE_GP, 16, xPSR &~ 0xff);
    
    	/* Now we can load SP core registers */
    
    	for (i = ARMV7M_PRIMASK; i < ARMV7NUMCOREREGS; i++)
    	{
    		if (!armv7m->core_cache->reg_list[i].valid)
    
    			armv7m->read_core_reg(target, i);
    
    	if (xPSR & 0x1FF)
    	{
    		armv7m->core_mode = ARMV7M_MODE_HANDLER;
    		armv7m->exception_number = (xPSR & 0x1FF);
    	}
    	else
    	{
    		armv7m->core_mode = buf_get_u32(armv7m->core_cache->reg_list[ARMV7M_CONTROL].value, 0, 1);
    		armv7m->exception_number = 0;
    	}
    	
    
    	if (armv7m->exception_number)
    	{
    		cortex_m3_examine_exception_reason(target);
    	}
    
    
    	LOG_DEBUG("entered debug state in core mode: %s at PC 0x%x, target->state: %s", 
    
    		armv7m_mode_strings[armv7m->core_mode],
    		*(u32*)(armv7m->core_cache->reg_list[15].value), 
    		Jim_Nvp_value2name_simple( nvp_target_state, target->state )->name);
    
    
    	if (armv7m->post_debug_entry)
    		armv7m->post_debug_entry(target);
    
    	return ERROR_OK;
    }
    
    
    int cortex_m3_poll(target_t *target)
    
    	enum target_state prev_target_state = target->state;
    
    	
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    
    	/* Read from Debug Halting Control and Status Register */
    
    	retval = mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &cortex_m3->dcb_dhcsr);
    
    	if (retval != ERROR_OK)
    	{
    		target->state = TARGET_UNKNOWN;
    
    		return retval;
    
    	if (cortex_m3->dcb_dhcsr & S_RESET_ST)
    
    		/* check if still in reset */
    
    		mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &cortex_m3->dcb_dhcsr);
    
    		
    		if (cortex_m3->dcb_dhcsr & S_RESET_ST)
    		{
    			target->state = TARGET_RESET;
    
    			return ERROR_OK;
    
    	
    	if (target->state == TARGET_RESET)
    
    	{
    		/* Cannot switch context while running so endreset is called with target->state == TARGET_RESET */
    
    		LOG_DEBUG("Exit from reset with dcb_dhcsr 0x%x", cortex_m3->dcb_dhcsr);
    
    		cortex_m3_endreset_event(target);
    		target->state = TARGET_RUNNING;
    		prev_target_state = TARGET_RUNNING;
    	}
    	
    
    	if (cortex_m3->dcb_dhcsr & S_HALT)
    
    	{
    		target->state = TARGET_HALTED;
    
    		if ((prev_target_state == TARGET_RUNNING) || (prev_target_state == TARGET_RESET))
    		{
    			if ((retval = cortex_m3_debug_entry(target)) != ERROR_OK)
    
    				return retval;
    
    			
    			target_call_event_callbacks(target, TARGET_EVENT_HALTED);
    		}
    		if (prev_target_state == TARGET_DEBUG_RUNNING)
    		{
    
    			if ((retval = cortex_m3_debug_entry(target)) != ERROR_OK)
    
    				return retval;
    
    
    			target_call_event_callbacks(target, TARGET_EVENT_DEBUG_HALTED);
    		}
    	}
    		
    	/*
    
    	if (cortex_m3->dcb_dhcsr & S_SLEEP)
    
    	/* Read Debug Fault Status Register, added to figure out the lockup when running flashtest.script  */
    
    	mem_ap_read_atomic_u32(swjdp, NVIC_DFSR, &cortex_m3->nvic_dfsr);
    
    	LOG_DEBUG("dcb_dhcsr 0x%x, nvic_dfsr 0x%x, target->state: %s", cortex_m3->dcb_dhcsr, cortex_m3->nvic_dfsr, Jim_Nvp_value2name_simple( nvp_target_state, target->state )->name );
    
    	return ERROR_OK;
    
    	LOG_DEBUG("target->state: %s", 
    
    		Jim_Nvp_value2name_simple(nvp_target_state, target->state )->name);
    
    	if (target->state == TARGET_HALTED)
    	{
    
    		LOG_DEBUG("target was already halted");
    
    oharboe's avatar
     
    oharboe committed
    		return ERROR_OK;
    
    	}
    	
    	if (target->state == TARGET_UNKNOWN)
    	{
    
    		LOG_WARNING("target was in unknown state when halt was requested");
    
    	}
    	
    	if (target->state == TARGET_RESET) 
    	{
    		if ((jtag_reset_config & RESET_SRST_PULLS_TRST) && jtag_srst)
    		{
    
    			LOG_ERROR("can't request a halt while in reset if nSRST pulls nTRST");
    
    			return ERROR_TARGET_FAILURE;
    		}
    		else
    		{
    			/* we came here in a reset_halt or reset_init sequence
    			 * debug entry was already prepared in cortex_m3_prepare_reset_halt()
    			 */
    			target->debug_reason = DBG_REASON_DBGRQ;
    			
    			return ERROR_OK; 
    		}
    	}
    
    
    	/* Write to Debug Halting Control and Status Register */
    
    	cortex_m3_write_debug_halt_mask(target, C_HALT, 0);
    
    
    	target->debug_reason = DBG_REASON_DBGRQ;
    	
    	return ERROR_OK;
    }
    
    int cortex_m3_soft_reset_halt(struct target_s *target)
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	u32 dcb_dhcsr = 0;
    	int retval, timeout = 0;
    
    
    	/* Enter debug state on reset, cf. end_reset_event() */
    
    	mem_ap_write_u32(swjdp, DCB_DEMCR, TRCENA | VC_HARDERR | VC_BUSERR | VC_CORERESET);
    
    	mem_ap_write_atomic_u32(swjdp, NVIC_AIRCR, AIRCR_VECTKEY | AIRCR_VECTRESET);
    
    	target->state = TARGET_RESET;
    
    	/* registers are now invalid */
    	armv7m_invalidate_core_regs(target);
    
    
    		retval = mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &dcb_dhcsr);
    
    			mem_ap_read_atomic_u32(swjdp, NVIC_DFSR, &cortex_m3->nvic_dfsr);
    
    			if ((dcb_dhcsr & S_HALT) && (cortex_m3->nvic_dfsr & DFSR_VCATCH))
    
    				LOG_DEBUG("system reset-halted, dcb_dhcsr 0x%x, nvic_dfsr 0x%x", dcb_dhcsr, cortex_m3->nvic_dfsr);
    
    				cortex_m3_poll(target);
    				return ERROR_OK;
    			}
    			else
    
    				LOG_DEBUG("waiting for system reset-halt, dcb_dhcsr 0x%x, %i ms", dcb_dhcsr, timeout);
    
    		alive_sleep(1);
    
    	}
    		
    	return ERROR_OK;
    }
    
    int cortex_m3_resume(struct target_s *target, int current, u32 address, int handle_breakpoints, int debug_execution)
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	breakpoint_t *breakpoint = NULL;
    
    		LOG_WARNING("target not halted");
    
    		return ERROR_TARGET_NOT_HALTED;
    	}
    	
    	if (!debug_execution)
    	{
    		target_free_all_working_areas(target);
    		cortex_m3_enable_breakpoints(target);
    		cortex_m3_enable_watchpoints(target);
    	}
    	
    	if (debug_execution)
    	{
    		/* Disable interrupts */
    
    		/* We disable interrupts in the PRIMASK register instead of masking with C_MASKINTS,
    
    		 * This is probably the same issue as Cortex-M3 Errata	377493: 
    
    		 * C_MASKINTS in parallel with disabled interrupts can cause local faults to not be taken. */
    
    		buf_set_u32(armv7m->core_cache->reg_list[ARMV7M_PRIMASK].value, 0, 32, 1);
    
    		armv7m->core_cache->reg_list[ARMV7M_PRIMASK].dirty = 1;
    		armv7m->core_cache->reg_list[ARMV7M_PRIMASK].valid = 1;
    
    
    		/* Make sure we are in Thumb mode */
    		buf_set_u32(armv7m->core_cache->reg_list[ARMV7M_xPSR].value, 0, 32, 
    
    			buf_get_u32(armv7m->core_cache->reg_list[ARMV7M_xPSR].value, 0, 32) | (1<<24));
    
    		armv7m->core_cache->reg_list[ARMV7M_xPSR].dirty = 1;
    		armv7m->core_cache->reg_list[ARMV7M_xPSR].valid = 1;
    
    	}
    
    	/* current = 1: continue on current pc, otherwise continue at <address> */
    	if (!current) 
    	{
    		buf_set_u32(armv7m->core_cache->reg_list[15].value, 0, 32, address);
    		armv7m->core_cache->reg_list[15].dirty = 1;
    		armv7m->core_cache->reg_list[15].valid = 1;
    	}
    	
    	resume_pc = buf_get_u32(armv7m->core_cache->reg_list[15].value, 0, 32);
    
    
    	armv7m_restore_context(target);
    
    	
    	/* the front-end may request us not to handle breakpoints */
    	if (handle_breakpoints)
    	{
    		/* Single step past breakpoint at current address */
    		if ((breakpoint = breakpoint_find(target, resume_pc)))
    		{
    
    			LOG_DEBUG("unset breakpoint at 0x%8.8x", breakpoint->address);
    			cortex_m3_unset_breakpoint(target, breakpoint);
    			cortex_m3_single_step_core(target);
    			cortex_m3_set_breakpoint(target, breakpoint);
    
    	cortex_m3_write_debug_halt_mask(target, 0, C_HALT);
    	
    
    	target->debug_reason = DBG_REASON_NOTHALTED;
    
    	/* registers are now invalid */
    	armv7m_invalidate_core_regs(target);
    	if (!debug_execution)
    	{
    		target->state = TARGET_RUNNING;
    		target_call_event_callbacks(target, TARGET_EVENT_RESUMED);
    
    		LOG_DEBUG("target resumed at 0x%x", resume_pc);
    
    	}
    	else
    	{
    		target->state = TARGET_DEBUG_RUNNING;
    		target_call_event_callbacks(target, TARGET_EVENT_DEBUG_RESUMED);
    
    		LOG_DEBUG("target debug resumed at 0x%x", resume_pc);
    
    /* int irqstepcount=0; */
    
    int cortex_m3_step(struct target_s *target, int current, u32 address, int handle_breakpoints)
    {
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    	breakpoint_t *breakpoint = NULL;
    
    	if (target->state != TARGET_HALTED)
    	{
    
    		LOG_WARNING("target not halted");
    
    		return ERROR_TARGET_NOT_HALTED;
    	}
    
    	/* current = 1: continue on current pc, otherwise continue at <address> */
    	if (!current)
    		buf_set_u32(armv7m->core_cache->reg_list[15].value, 0, 32, address);
    	
    	/* the front-end may request us not to handle breakpoints */
    	if (handle_breakpoints)
    		if ((breakpoint = breakpoint_find(target, buf_get_u32(armv7m->core_cache->reg_list[15].value, 0, 32))))
    			cortex_m3_unset_breakpoint(target, breakpoint);
    	
    	target->debug_reason = DBG_REASON_SINGLESTEP;
    	
    
    	armv7m_restore_context(target);
    
    	
    	target_call_event_callbacks(target, TARGET_EVENT_RESUMED);
    
    	/* set step and clear halt */
    	cortex_m3_write_debug_halt_mask(target, C_STEP, C_HALT);
    
    	mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &cortex_m3->dcb_dhcsr);
    
    	/* registers are now invalid */
    	armv7m_invalidate_core_regs(target);
    
    	
    	if (breakpoint)
    		cortex_m3_set_breakpoint(target, breakpoint);
    
    
    	LOG_DEBUG("target stepped dcb_dhcsr = 0x%x nvic_icsr = 0x%x", cortex_m3->dcb_dhcsr, cortex_m3->nvic_icsr);
    
    
    	cortex_m3_debug_entry(target);
    	target_call_event_callbacks(target, TARGET_EVENT_HALTED);
    
    
    	LOG_DEBUG("target stepped dcb_dhcsr = 0x%x nvic_icsr = 0x%x", cortex_m3->dcb_dhcsr, cortex_m3->nvic_icsr);
    
    	return ERROR_OK;
    }
    
    int cortex_m3_assert_reset(target_t *target)
    {
    
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    
    	swjdp_common_t *swjdp = &armv7m->swjdp_info;
    
    oharboe's avatar
    oharboe committed
    	int assert_srst = 1;
    
    	LOG_DEBUG("target->state: %s", 
    
    		Jim_Nvp_value2name_simple( nvp_target_state, target->state )->name );
    
    	if (!(jtag_reset_config & RESET_HAS_SRST))
    	{
    		LOG_ERROR("Can't assert SRST");
    		return ERROR_FAIL;
    	}
    
    oharboe's avatar
     
    oharboe committed
    	
    
    	mem_ap_read_atomic_u32(swjdp, DCB_DHCSR, &cortex_m3->dcb_dhcsr);
    
    	if (!(cortex_m3->dcb_dhcsr & C_DEBUGEN))
    
    		mem_ap_write_u32(swjdp, DCB_DHCSR, DBGKEY | C_DEBUGEN);
    
    	mem_ap_write_u32(swjdp, DCB_DCRDR, 0 );
    
    oharboe's avatar
     
    oharboe committed
    	if (!target->reset_halt)
    
    	{
    		/* Set/Clear C_MASKINTS in a separate operation */
    		if (cortex_m3->dcb_dhcsr & C_MASKINTS)
    
    			mem_ap_write_atomic_u32(swjdp, DCB_DHCSR, DBGKEY | C_DEBUGEN | C_HALT);
    
    
    		/* clear any debug flags before resuming */
    
    		cortex_m3_clear_halt(target);
    
    		
    		/* clear C_HALT in dhcsr reg */
    		cortex_m3_write_debug_halt_mask(target, 0, C_HALT);
    
    							
    		/* Enter debug state on reset, cf. end_reset_event() */	
    
    		mem_ap_write_u32(swjdp, DCB_DEMCR, TRCENA | VC_HARDERR | VC_BUSERR);
    
    	else
    	{
    		/* Enter debug state on reset, cf. end_reset_event() */
    
    		mem_ap_write_atomic_u32(swjdp, DCB_DEMCR, TRCENA | VC_HARDERR | VC_BUSERR | VC_CORERESET);
    
    	/* following hack is to handle luminary reset
    	 * when srst is asserted the luminary device seesm to also clear the debug registers
    	 * which does not match the armv7 debug TRM */
    		
    
    	if (strcmp(target->variant, "lm3s") == 0)
    
    		/* get revision of lm3s target, only early silicon has this issue
    		 * Fury Rev B, DustDevil Rev B, Tempest all ok */
    		
    		u32 did0;
    		
    		if (target_read_u32(target, 0x400fe000, &did0) == ERROR_OK)
    		{
    			switch ((did0 >> 16) & 0xff)
    			{
    				case 0:
    					/* all Sandstorm suffer issue */
    
    oharboe's avatar
    oharboe committed
    					assert_srst = 0;
    
    					break;
    				
    				case 1:
    				case 3:
    					/* only Fury/DustDevil rev A suffer reset problems */
    					if (((did0 >> 8) & 0xff) == 0)
    
    oharboe's avatar
    oharboe committed
    						assert_srst = 0;
    
    oharboe's avatar
    oharboe committed
    	if (assert_srst)
    
    		/* default to asserting srst */
    
    		if (jtag_reset_config & RESET_SRST_PULLS_TRST)
    		{
    			jtag_add_reset(1, 1);
    		}
    		else
    		{
    			jtag_add_reset(0, 1);
    		}
    
    	else
    	{
    		/* this causes the luminary device to reset using the watchdog */
    
    		mem_ap_write_atomic_u32(swjdp, NVIC_AIRCR, AIRCR_VECTKEY | AIRCR_SYSRESETREQ);
    
    		LOG_DEBUG("Using Luminary Reset: SYSRESETREQ");
    
    
    		{
    			/* I do not know why this is necessary, but it fixes strange effects
    
    			 * (step/resume cause a NMI after reset) on LM3S6918 -- Michael Schwingen */
    
    			mem_ap_read_atomic_u32(swjdp, NVIC_AIRCR, &tmp);
    
    	
    	target->state = TARGET_RESET;
    	jtag_add_sleep(50000);
    	
    	armv7m_invalidate_core_regs(target);
    
    
    	if (target->reset_halt)
    	{
    		int retval;
    
    		if ((retval = target_halt(target))!=ERROR_OK)
    			return retval;
    
    	return ERROR_OK;
    }
    
    int cortex_m3_deassert_reset(target_t *target)
    
    	LOG_DEBUG("target->state: %s", 
    
    		Jim_Nvp_value2name_simple(nvp_target_state, target->state )->name);
    
    	
    	/* deassert reset lines */
    	jtag_add_reset(0, 0);
    		
    	return ERROR_OK;
    }
    
    void cortex_m3_enable_breakpoints(struct target_s *target)
    {
    	breakpoint_t *breakpoint = target->breakpoints;
    	
    	/* set any pending breakpoints */
    	while (breakpoint)
    	{
    		if (breakpoint->set == 0)
    			cortex_m3_set_breakpoint(target, breakpoint);
    		breakpoint = breakpoint->next;
    	}
    }
    
    int cortex_m3_set_breakpoint(struct target_s *target, breakpoint_t *breakpoint)
    {
    
    	int fp_num=0;
    	u32 hilo;
    	
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    	
    	cortex_m3_fp_comparator_t * comparator_list = cortex_m3->fp_comparator_list;
    
    	if (breakpoint->set)
    	{
    
    		LOG_WARNING("breakpoint already set");
    
    		breakpoint->type = (breakpoint->address < 0x20000000) ? BKPT_HARD : BKPT_SOFT;
    
    		while(comparator_list[fp_num].used && (fp_num < cortex_m3->fp_num_code))
    
    		if (fp_num >= cortex_m3->fp_num_code)
    
    			LOG_DEBUG("ERROR Can not find free FP Comparator");
    			LOG_WARNING("ERROR Can not find free FP Comparator");
    
    		breakpoint->set = fp_num + 1;
    		hilo = (breakpoint->address & 0x2) ? FPCR_REPLACE_BKPT_HIGH : FPCR_REPLACE_BKPT_LOW;
    
    		comparator_list[fp_num].used = 1;
    
    		comparator_list[fp_num].fpcr_value = (breakpoint->address & 0x1FFFFFFC) | hilo | 1;
    
    		target_write_u32(target, comparator_list[fp_num].fpcr_address, comparator_list[fp_num].fpcr_value);
    
    		LOG_DEBUG("fpc_num %i fpcr_value 0x%x", fp_num, comparator_list[fp_num].fpcr_value);
    
    		if (!cortex_m3->fpb_enabled)
    		{
    			LOG_DEBUG("FPB wasn't enabled, do it now");
    			target_write_u32(target, FP_CTRL, 3);
    		}
    
    	}
    	else if (breakpoint->type == BKPT_SOFT)
    	{
    		u8 code[4];
    		buf_set_u32(code, 0, 32, ARMV7M_T_BKPT(0x11));
    
    		if((retval = target->type->read_memory(target, breakpoint->address & 0xFFFFFFFE, breakpoint->length, 1, breakpoint->orig_instr)) != ERROR_OK)
    		{
    			return retval;
    		}
    		if((retval = target->type->write_memory(target, breakpoint->address & 0xFFFFFFFE, breakpoint->length, 1, code)) != ERROR_OK)
    		{
    			return retval;
    		}
    
    		breakpoint->set = 0x11; /* Any nice value but 0 */
    	}
    
    	return ERROR_OK;
    }
    
    int cortex_m3_unset_breakpoint(struct target_s *target, breakpoint_t *breakpoint)
    {
    
    	/* get pointers to arch-specific information */
    	armv7m_common_t *armv7m = target->arch_info;
    	cortex_m3_common_t *cortex_m3 = armv7m->arch_info;
    	cortex_m3_fp_comparator_t * comparator_list = cortex_m3->fp_comparator_list;
    
    	if (!breakpoint->set)
    	{
    
    		LOG_WARNING("breakpoint not set");
    
    		return ERROR_OK;
    	}
    	
    	if (breakpoint->type == BKPT_HARD)
    	{
    
    		int fp_num = breakpoint->set - 1;
    		if ((fp_num < 0) || (fp_num >= cortex_m3->fp_num_code))
    
    			LOG_DEBUG("Invalid FP Comparator number in breakpoint");
    
    			return ERROR_OK;
    		}
    		comparator_list[fp_num].used = 0;
    		comparator_list[fp_num].fpcr_value = 0;
    		target_write_u32(target, comparator_list[fp_num].fpcr_address, comparator_list[fp_num].fpcr_value);
    	}
    	else
    	{
    		/* restore original instruction (kept in target endianness) */
    		if (breakpoint->length == 4)
    		{
    
    			if((retval = target->type->write_memory(target, breakpoint->address & 0xFFFFFFFE, 4, 1, breakpoint->orig_instr)) != ERROR_OK)
    			{
    				return retval;
    			}
    
    			if((retval = target->type->write_memory(target, breakpoint->address & 0xFFFFFFFE, 2, 1, breakpoint->orig_instr)) != ERROR_OK)
    			{
    				return retval;
    			}