Skip to content
Snippets Groups Projects
Commit 0f6a4783 authored by zwelch's avatar zwelch
Browse files

Simplify and improve handle_debug_level_comamnd:

- Bug fix: Return a syntax error if more than one argument is given.
- Bug fix: Use new parse_uint helper ensure debug_level parses correctly.
- Change: Display the debug_level after it has been set.
- Simplify bounds checking of debug_level.


git-svn-id: svn://svn.berlios.de/openocd/trunk@2208 b42882b7-edfa-0310-969c-e2dbd0fdcd60
parent 5af1bdcf
No related branches found
No related tags found
No related merge requests found
...@@ -194,17 +194,18 @@ void log_printf_lf(enum log_levels level, const char *file, int line, const char ...@@ -194,17 +194,18 @@ void log_printf_lf(enum log_levels level, const char *file, int line, const char
*/ */
int handle_debug_level_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc) int handle_debug_level_command(struct command_context_s *cmd_ctx, char *cmd, char **args, int argc)
{ {
if (argc == 0) if (argc == 1)
command_print(cmd_ctx, "debug_level: %i", debug_level); {
unsigned new_level;
if (argc > 0) int retval = parse_uint(args[0], &new_level);
debug_level = strtoul(args[0], NULL, 0); if (ERROR_OK != retval)
return retval;
if (debug_level < 0) debug_level = MIN(new_level, LOG_LVL_DEBUG);
debug_level = 0; }
else if (argc > 1)
return ERROR_COMMAND_SYNTAX_ERROR;
if (debug_level > 3) command_print(cmd_ctx, "debug_level: %i", debug_level);
debug_level = 3;
if (debug_level >= LOG_LVL_DEBUG && server_use_pipes == 1) if (debug_level >= LOG_LVL_DEBUG && server_use_pipes == 1)
{ {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment