Skip to content
Snippets Groups Projects
Commit 15ae1ac6 authored by zwelch's avatar zwelch
Browse files

Factoring of jtag_examine_chain for maintainability:

- Reduce indent: invert logic test for unexpected TAP (no IDs).


git-svn-id: svn://svn.berlios.de/openocd/trunk@2081 b42882b7-edfa-0310-969c-e2dbd0fdcd60
parent 32350a50
No related branches found
No related tags found
No related merge requests found
...@@ -1058,7 +1058,16 @@ static int jtag_examine_chain(void) ...@@ -1058,7 +1058,16 @@ static int jtag_examine_chain(void)
tap->idcode = idcode; tap->idcode = idcode;
if (tap->expected_ids_cnt > 0) { if (0 == tap->expected_ids_cnt)
{
// @todo Enable LOG_INFO to ask for reports about unknown TAP IDs.
#if 0
LOG_INFO("Uknown JTAG TAP ID: 0x%08x", tap->idcode)
LOG_INFO("Please report the chip name and reported ID code to the openocd project");
#endif
tap = jtag_tap_next_enabled(tap);
continue;
}
/* Loop over the expected identification codes and test for a match */ /* Loop over the expected identification codes and test for a match */
u8 ii; u8 ii;
for (ii = 0; ii < tap->expected_ids_cnt; ii++) { for (ii = 0; ii < tap->expected_ids_cnt; ii++) {
...@@ -1090,12 +1099,7 @@ static int jtag_examine_chain(void) ...@@ -1090,12 +1099,7 @@ static int jtag_examine_chain(void)
} else { } else {
LOG_INFO("JTAG Tap/device matched"); LOG_INFO("JTAG Tap/device matched");
} }
} else {
#if 0
LOG_INFO("JTAG TAP ID: 0x%08x - Unknown - please report (A) chipname and (B) idcode to the openocd project",
tap->idcode);
#endif
}
tap = jtag_tap_next_enabled(tap); tap = jtag_tap_next_enabled(tap);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment