py: use InputController in simple_drums

assigned to @dx

added 1 commit

• 0ba7b684 - py: allow disabling input repeat, use InputController in simple_drums

Compare with previous version

added 3 commits

• 0ba7b684...0abef408 - 2 commits from branch main
• a4678a17 - py: use InputController in simple_drums

Compare with previous version

Had a look, but deferring to @moon2 who's afk today but has some valid points.

changed title from py: allow disabling input repeat, use InputController in simple_drums to py: use InputController in simple_drums

        # True if a given track should be highlighted, when a corresponding
        # petal is pressed.
        self._bar_highlight = [False for _ in range(4)]

"bar" is a reserved term in music, so let's not use it here to avoid confusion - in the current settings the entire 16 beats represent a bar actually. We can understand the confusion with the vertical lines as they resemble bar lines in music notation, but they're really just a visual aid to make it easier to align stuff and represent quarter notes atm, but with a more flexible config they could really be anything. Maybe we should use a different symbol (dotted lines or smth) there, but we'll change up looks someday soon anyways and can just do it then.

Below we use "groupgap" with "group" referring to one of the highlightable units, so maybe rename _bar_hightlight to _group_highlight? Also we think in the comment you mean "bar"(->group) when you say "track", which is a reserved term of the sequencer, if that is the case please correct accordingly to whatever you change the variable name to.

Rest looks good!

added 37 commits

• a4678a17...9f6a6b28 - 36 commits from branch main
• 82cd658e - py: use InputController in simple_drums

Compare with previous version

Renamed bar to group, rebased on top of newer changes. Please take a look.

added 1 commit

• 31a1ec74 - py: use InputController in simple_drums

Compare with previous version

looks good, go ahead

approved this merge request

added 9 commits

• 31a1ec74...f06d3bd0 - 8 commits from branch main
• 36d14db5 - py: use InputController in simple_drums

Compare with previous version

enabled an automatic merge when the pipeline for 36d14db5 succeeds

merged