Skip to content

py,st3m: Split SunMenu and MainMenu; LED fix

dos requested to merge sunmenu into main

SunMenu is just a presentation layer that doesn't concern itself with any kind of logic. It could be simply replaced with (already existing) SimpleMenu and FlowerMenu or, in the future, may even become customizable by the user.

Split the main menu's logic into a separate entity that delegates the presentation to the class it inherits from, like all the other uses of the menu system.

Also, move menu LED pattern setting back later in the boot process.

Since !620 (merged) it happened much earlier, causing a lot of flickering at boot, especially with plenty of apps installed. Move it back to until after the application bundles are already collected.

Note that it happens a bit later than before now, as bundle processing itself happens later because of being moved into the menu class, but the end result is arguably nicer than before, as there's no weird delay between setting the LEDs and showing the menu anymore.

@ave, since I don't know what the "Reasons™ that will become clear in the near future" are - is this something that works for what you want to achieve? the question answered itself in the meanwhile.

Edited by dos

Merge request reports