Skip to content
Snippets Groups Projects

py: re-introduce os/app button naming, pop views on os button press

Merged q3k requested to merge q3k/os-app-buttons into main
All threads resolved!

This finally bakes in some UX assumptions about the meaning of each button.

The app button (by default the left button) is for exclusive use by applications. In the menu, the app button is used to go left/right and to select an option.

The os button (by default the right button) is for exclusive use by the OS. It always adjusts the volume and allows the user to navigate back (either exit the app or go back in menus).

Edited by q3k

Merge request reports

Pipeline #6371 passed

Pipeline passed for 0cfa7433 on q3k/os-app-buttons

Approval is optional

Merged by q3kq3k 1 year ago (Aug 11, 2023 12:07pm UTC)

Merge details

  • Changes merged into main with 0cfa7433.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #6372 passed

Pipeline passed for 0cfa7433 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • q3k added 7 commits

    added 7 commits

    • 943f5878...e830141f - 4 commits from branch main
    • 045b56ee - py: re-introduce os/app button naming
    • deb3b640 - py/shoegaze: use InputController
    • b1bfdacf - py/st3m: move view popping to ViewManager / os button, update docs

    Compare with previous version

    • Resolved by q3k

      tiny thing: pressing "swap buttons" in the settings exits the settings (i.e., 1 new back-button event is registered).

  • q3k added 1 commit

    added 1 commit

    • b32e528e - py/st3m: fix spurious presses on button swap

    Compare with previous version

  • schneider resolved all threads

    resolved all threads

  • q3k added 5 commits

    added 5 commits

    • 56207371 - 1 commit from branch main
    • 41b7dd6d - py: re-introduce os/app button naming
    • 25dbcaa2 - py/shoegaze: use InputController
    • adbf0f8b - py/st3m: move view popping to ViewManager / os button, update docs
    • 0cfa7433 - py/st3m: fix spurious presses on button swap

    Compare with previous version

  • q3k enabled an automatic merge when the pipeline for 0cfa7433 succeeds

    enabled an automatic merge when the pipeline for 0cfa7433 succeeds

  • q3k merged

    merged

  • Please register or sign in to reply
    Loading