Skip to content
Snippets Groups Projects

fix issues related to incorrect app termination

Closed Phileas requested to merge patch-1 into main
Edited by Phileas

Merge request reports

Closed by PhileasPhileas 1 year ago (Aug 26, 2023 11:07am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Phileas added 19 commits

    added 19 commits

    Compare with previous version

    By Max Bachmann on 2023-08-16T01:56:44 (imported from GitLab)

  • Author Owner

    This does not reset leds yet, so they are still active after closing an app. It could make sense for the "OS" to do this instead of the App, but I can implement it either way.

    By Max Bachmann on 2023-08-16T15:45:53 (imported from GitLab)

    Edited by Phileas
  • Phileas changed the description

    changed the description

    By Max Bachmann on 2023-08-16T15:42:11 (imported from GitLab)

  • Phileas mentioned in issue #55 (closed)

    mentioned in issue #55 (closed)

    By Max Bachmann on 2023-08-16T15:43:18 (imported from GitLab)

  • Phileas added 6 commits

    added 6 commits

    Compare with previous version

    By Max Bachmann on 2023-08-16T21:30:22 (imported from GitLab)

  • Author Owner

    Uhhhh not sure I understand the issue this is trying to fix but keeping sound running after the application is backgrounded is intended behavior.

    Other than that, this MR is doing several things at the same time and I don't think I can review it.

    By dx on 2023-08-19T20:22:37 (imported from GitLab)

  • Author Owner

    There exist other problems with 2 apps trying to update the screen simultaniously or 2 sound apps running through each other. It's a mess.

    @dx : Could you specify the intended behaviour that looks acceptable?

    By Jelle Haandrikman on 2023-08-22T10:18:42 (imported from GitLab)

  • Author Owner

    sorry, fixed them ourselves in !218 (merged), !221 (merged), didn't see this.

    it does appear that you continue using the channel in the next on_enter after freeing it. this is not advised because another application might be using it. we should clarify the docs there.

    By moon2 on 2023-08-26T11:16:09 (imported from GitLab)

    Edited by Phileas
  • closed

Please register or sign in to reply
Loading