fix issues related to incorrect app termination
- lingering audio on music app exit (#50 (closed))
- graphics issues when reentering the
gay_drums
app (#55 (closed))
Merge request reports
Activity
added 19 commits
-
25e860f6...fee7e552 - 18 commits from branch
flow3r:main
- bd894bc4 - fix issues related to incorrect app termination
By Max Bachmann on 2023-08-16T01:56:44 (imported from GitLab)
-
25e860f6...fee7e552 - 18 commits from branch
This does not reset leds yet, so they are still active after closing an app. It could make sense for the "OS" to do this instead of the App, but I can implement it either way.
By Max Bachmann on 2023-08-16T15:45:53 (imported from GitLab)
Edited by Phileasmentioned in issue #55 (closed)
By Max Bachmann on 2023-08-16T15:43:18 (imported from GitLab)
added 6 commits
-
bd894bc4...dd6ad21c - 5 commits from branch
flow3r:main
- 34fe6bcc - fix issues related to incorrect app termination
By Max Bachmann on 2023-08-16T21:30:22 (imported from GitLab)
-
bd894bc4...dd6ad21c - 5 commits from branch
Uhhhh not sure I understand the issue this is trying to fix but keeping sound running after the application is backgrounded is intended behavior.
Other than that, this MR is doing several things at the same time and I don't think I can review it.
By dx on 2023-08-19T20:22:37 (imported from GitLab)
There exist other problems with 2 apps trying to update the screen simultaniously or 2 sound apps running through each other. It's a mess.
@dx : Could you specify the intended behaviour that looks acceptable?
By Jelle Haandrikman on 2023-08-22T10:18:42 (imported from GitLab)
sorry, fixed them ourselves in !218 (merged), !221 (merged), didn't see this.
it does appear that you continue using the channel in the next on_enter after freeing it. this is not advised because another application might be using it. we should clarify the docs there.
By moon2 on 2023-08-26T11:16:09 (imported from GitLab)
Edited by Phileas