Closes #192

See merge request card10/firmware!360

Signed-off-by: Rahix <rahix@rahix.de>

With the increased warning-level, GCC warns about three unused fields in
`bleSmpCfg`:

    - maxAttemptTimeout: Maximum 'Repeated attempts' timeout in msec
    - attemptDecTimeout: Time msec before attemptExp decreases
    - attemptExp: Exponent to raise attemptTimeout on maxAttempts

These should probably be set to sensible values but to make !360
mergeable, explicitly set them to zero for now.

Signed-off-by: Rahix <rahix@rahix.de>

Signed-off-by: Rahix <rahix@rahix.de>

By passing `&resched` instead of just `resched`, the internal comparison
in FreeRTOS would always evaluate to rescheduling.  Curiously, only some
GCC versions emit the -Waddress warning for this while others do not ...

Signed-off-by: Rahix <rahix@rahix.de>

Fix sign-compare warnings for these constants.

Signed-off-by: Rahix <rahix@rahix.de>

Signed-off-by: Rahix <rahix@rahix.de>

It does not make sense for the filesize to be given as `int`; it cannot
ever be negative.  Instead, use `size_t` which is unsigned.

Signed-off-by: Rahix <rahix@rahix.de>

Fix all warnings in pycardium/modules.

Signed-off-by: Rahix <rahix@rahix.de>

Fix all warnings in epicardium/modules.

Signed-off-by: Rahix <rahix@rahix.de>

Make the length parameter a `size_t` instead of a `intptr_t`.  A signed
value does not make any sense here and just leads to weird behavior if a
negative value is given nonetheless.

See issue card10/firmware#192

Signed-off-by: Rahix <rahix@rahix.de>

Signed-off-by: Rahix <rahix@rahix.de>

Signed-off-by: Rahix <rahix@rahix.de>

Signed-off-by: Rahix <rahix@rahix.de>

Disable the `unused-parameter` warning for the mpy-cross-wrapper to
silence an error about `argc` being unused (which is ok).

Signed-off-by: Rahix <rahix@rahix.de>

Signed-off-by: Rahix <rahix@rahix.de>

The crc_patch utility displays the following warning:

    bootloader/./crc_patch.py:31: DeprecationWarning: PY_SSIZE_T_CLEAN
        will be required for '#' formats

We cannot fix the offending library so disable the warnings to prevent
unnecessary build-log clutter.

Signed-off-by: Rahix <rahix@rahix.de>

Fix the following warning:

    lib/sdk/Libraries/Boards/card10/Source/board.c: In function 'Board_Init':
    lib/sdk/Libraries/Boards/card10/Source/board.c:102:19: warning:
             comparison of integer expressions of different signedness:
             'int' and 'unsigned int' [-Wsign-compare]
      102 |     for (i = 0; i < num_pins; i++) {
          |                   ^

Signed-off-by: Rahix <rahix@rahix.de>

Fix all warnings found by `-Wsign-compare` in epicardium/api.

Signed-off-by: Rahix <rahix@rahix.de>

As discussed in card10/firmware!357, we should increase the number of
enabled compiler warnings to catch a lot more silent bugs.  Increase the
meson-global warning level to 2, but excluding the `unused-parameter`
and `old-style-declaration` warnings.  Additionally, disable warnings
for libraries as we cannot fix that code anyway.

Signed-off-by: Rahix <rahix@rahix.de>

Signed-off-by: Rahix <rahix@rahix.de>

See merge request card10/firmware!339

As opposed to defining all possible keys at compile time.

In preparation for next commit

Mostly changing things like if { ... return} else { ... } to not have
an extra indentation level of the else part.

The diff is probably very weird even with stripped whitespace.

Added a page to the wiki which describes how to setup NimBLE on the ESP32.

See merge request card10/firmware!358

Fix faulty error handling due to always-false unsigned comparisons.
`-Wtype-limits` revealed three errors in the firmware:

    ../pycardium/modules/sys_leds.c: In function 'mp_leds_get_rocket':
    ../pycardium/modules/sys_leds.c:207:10: warning: comparison is
                always false due to limited range of data type [-Wtype-limits]
      207 |  if (ret == -EINVAL) {
          |          ^~


    ../pycardium/mphalport.c: In function 'mp_hal_set_interrupt_char':
    ../pycardium/mphalport.c:115:8: warning: comparison is always true
                due to limited range of data type [-Wtype-limits]
      115 |  if (c != -1) {
          |        ^~

    ../epicardium/modules/bhi.c: In function 'epic_bhi160_enable_sensor':
    ../epicardium/modules/bhi.c:134:12: warning: comparison is always
                false due to limited range of data type [-Wtype-limits]
      134 |  if (vs_id < 0) {
          |            ^
    ../epicardium/modules/bhi.c: In function 'epic_bhi160_disable_sensor':
    ../epicardium/modules/bhi.c:191:12: warning: comparison is always
                false due to limited range of data type [-Wtype-limits]
      191 |  if (vs_id < 0) {
          |            ^

Note that on the target platform `char` and `enum`s are unsigned.  The
compiler has probably removed all of these `if`s so far because the
conditions were determined to always be false.

See merge request card10/firmware!357