Skip to content
Snippets Groups Projects

Adds Docker for firmware-building

Closed Sistason requested to merge sistason/firmware:master into master

This commit adds a Dockerfile to build a docker container to build the firmware with. It also updates the documentation on how to do that.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good to me! Thanks for keeping our codebase clean.

    However, I'm only a bot - so a human will still have to approve this request.

  • We already have a docker/ folder for the CI environments. Maybe you can put the Dockerfile in there as well?

  • added 3-Other label

  • The docker/ folder is for internal CI to build the docu. This Dockerfile is logically on the same level as bootstrap.sh (it builds the firmware), therefore I put it in main, instead of Documentation or such. But you could view it as a file to build the helper-container, which could go to Documentation, if you want to limit your main directory.

  • rahix mentioned in commit f0d94559

    mentioned in commit f0d94559

  • I've manually merged this in commit f0d94559 ("feat(build): Add a Dockerfile for firmware building").

  • closed

Please register or sign in to reply
Loading