Skip to content
Snippets Groups Projects

feat(simple_menu): Make scroll buttons configurable

Merged Philip Stewart requested to merge sodoku/firmware:right_scroll_config into master
All threads resolved!

This introduces a config flag to make the right buttons scrollable. I wasn't sure if I should just remove the old option in SimpleMenu but left it for backwards compatibility. If the config is set, it overwrites the SimpleMenu option.

I tested it with the main menu and the menu in the ecg app.

Fixes #204 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • One minor comment, apart from that it LGTM! @schneider, I suppose we can still get this in to 1.16?

  • Philip Stewart added 1 commit

    added 1 commit

    • 0b489600 - style(simple_menu): make code more readable

    Compare with previous version

  • Author Contributor

    @rahix thanks for the quick review. I added your changes.

  • rahix resolved all threads

    resolved all threads

  • rahix approved this merge request

    approved this merge request

  • merged

  • rahix mentioned in commit 593be3c3

    mentioned in commit 593be3c3

  • Please register or sign in to reply
    Loading