Implement portexpander button callbacks + change portexpander API to match GPIO

added 1 commit

• f81b7e65 - Format leds.c to shut up annoyatron

Compare with previous version

added 3-Epicardium label

mentioned in merge request !77 (merged)

Hey @Woazboat, sorry for the silence. The LED changeset has been merged in e87cdd45. Can you please rebase your changes ontop of that and maybe adjust the LED module to use your new functions?

added 50 commits

• f81b7e65...b3979a7d - 47 commits from branch card10:master
• 15f4f36d - refactor(portexpander): Adjust portexpander API to match GPIO + portexpander interrupt handling
• a4249525 - feat(pb): Implement callbacks for portexpander buttons + fix off-by-1 bug
• c49d68a0 - Format leds.c to shut up annoyatron

Compare with previous version

added 11 commits

• c49d68a0...97563e66 - 9 commits from branch card10:master
• a9da1511 - refactor(portexpander): Adjust portexpander API to match GPIO + portexpander interrupt handling
• c6482266 - feat(pb): Implement callbacks for portexpander buttons + fix off-by-1 bug

Compare with previous version

added 1 commit

• 6cd25692 - refactor(leds): Use new portexpander API for leds

Compare with previous version

added 1 commit

• 700af010 - refactor(leds): Use new portexpander API for leds

Compare with previous version

Looks good to me! Thanks for keeping our codebase clean.

However, I'm only a bot - so a human will still have to approve this request.

@schneider you are more familiar with the code in the affected modules, can you please take a quick look?

assigned to @rahix

added 19 commits

• 700af010...d23fbdd0 - 16 commits from branch card10:master
• 87f69bd9 - refactor(portexpander): Adjust portexpander API to match GPIO + portexpander interrupt handling
• 8812362e - feat(pb): Implement callbacks for portexpander buttons + fix off-by-1 bug
• 378cfa14 - refactor(leds): Use new portexpander API for leds

Compare with previous version

rebased onto master again

unassigned @rahix

added 197 commits

• 378cfa14...2c60241a - 194 commits from branch card10:master
• e7718eee - refactor(portexpander): Adjust portexpander API to match GPIO + portexpander interrupt handling
• c230a0e0 - feat(pb): Implement callbacks for portexpander buttons + fix off-by-1 bug
• ca67af86 - refactor(leds): Use new portexpander API for leds

Compare with previous version

mentioned in merge request !185 (closed)

added 10 commits

• ca67af86...0608bfdc - 7 commits from branch card10:master
• 3c51ba78 - refactor(portexpander): Adjust portexpander API to match GPIO + portexpander interrupt handling
• b0ffa2a4 - feat(pb): Implement callbacks for portexpander buttons + fix off-by-1 bug
• f3b37987 - refactor(leds): Use new portexpander API for leds

Compare with previous version

added 3 commits

• d5b8dbcc - refactor(portexpander): Adjust portexpander API to match GPIO + portexpander interrupt handling
• 330659a1 - feat(pb): Implement callbacks for portexpander buttons + fix off-by-1 bug
• 94a640ef - refactor(leds): Use new portexpander API for leds

Compare with previous version

added 31 commits

• 94a640ef...2e84e69a - 28 commits from branch card10:master
• e3fb5084 - refactor(portexpander): Adjust portexpander API to match GPIO + portexpander interrupt handling
• 610b1600 - feat(pb): Implement callbacks for portexpander buttons + fix off-by-1 bug
• 41ef12b9 - refactor(leds): Use new portexpander API for leds

Compare with previous version