- Nov 06, 2009
-
-
David Brownell authored
Use target_to_arm926(), replacing needless pointer traversals and simplifying a bunch of code. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Replace needless pointer traversals, simplify. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Use target_to_arm920(), replacing needless pointer traversals and simplifying. Stop setting arm9tdmi->arch_info for arm920 type parts, it's not used any longer. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Use new target_to_cm3() and target_to_armv7m() inlines, instead of a series of x->arch_info conversions. Remove arch_info, since nothing uses it. Also fix an omission: the Cortex-M3 commands didn't verify that they were operating on that kind of target. Add comment about the ARMv7M version of that omission. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Provide a cleaner way to handle single inheritance of targets in C, using the same model Linux does: structs containing other structs, un-nested via calls to a "container_of()" macro that are packaged in typesafe inline functions. Targets already use this containment idiom, but make it much more complicated because they un-nest using embedded "void *" pointers ... in chains of up to five per target, which is all pure needless complication. (Example: arm92x core, arm9tdmi, arm7_9, armv4_5 ... on top of the base "target" class.) Applying this scheme consistently simplifies things, and gets rid of many error-prone untyped pointers. It won't change any part of the type model though -- it just simplifies things. (And facilitates more cleanup later on.) Rule of thumb: where there's an X->arch_info void* pointer, access to that pointer can and should be removed. It may be convenient to set up pointers to some of the embedded structs; and shrink their current "*_common" names (annoyingly long). Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
The forward decls are just code clutter; remove them, by moving their references after definitions. This is another file which never needed even one internal forward declaration. Also shrink a few overly-long lines with function declarations or definitions; get rid of arm7tdmi_register_commands(), it's not needed (just delegated); minor whitespace declutter. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Unneeded exports cause confusion about the module interfaces. Make all functions static. Add a short header comment. The forward decls are just code clutter; remove them, by moving their references after definitions. This is another file which never needed even one internal forward declaration. Remove unneeded indirection for the write_memory() method. Make a table static, remove a can't-happen case with nasty exit(). Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Unneeded exports cause confusion about the module interfaces. Make most functions static. The forward decls are just code clutter; remove them, by moving their references after definitions. This is another file which never needed even one internal forward declaration. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
The forward decls are just code clutter; remove them, by moving their references after definitions. This is another file which never needed even one internal forward declaration. Also shrink a few overly-long lines with function declarations or definitions. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Unneeded exports cause confusion about the module interfaces. Make most functions static. The forward decls are just code clutter; remove them, by moving their references after definitions. This is another file which never needed even one internal forward declaration. Also remove needless arm966e_init_target(), in favor of the arm9tdmi routine to which it delegates its work. This saved over 100 bytes of code on x86_32. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
An init_target() wrapper isn't needed, and target_create() can shrink a bit. Add a header comment and some doxygen. Remove arm926ejs_catch_broken_irscan() which has been a NOP for quite a few months now, and in any case duplicates logic in the JTAG core to validate IR capture data. But force the capture mask to 0x0f, so those tests are most effective. Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
David Brownell authored
Unneeded exports cause confusion about the module interfaces. Make most functions static. Add a short header comment. The forward decls are just code clutter; remove them, by moving their references after definitions. This is another file which never needed even one internal forward declaration. This saved almost 900 bytes of code on x86_32; it seems the compiler can leverage its knowledge that these functions are not called from the outside world... Signed-off-by:
David Brownell <dbrownell@users.sourceforge.net>
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
This fixes a memory leak in lpc3180_nand_device_command by reordering the malloc to occur after all parsing has completed.
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
This eliminates redundant code for parsing and retreiving the bank specified from a script command argument. This patch was written to replace existing functionality; however, the parsing logic can be updated later to allow flash commands to accept bank names as well as their numbers.
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-
Zachary T Welch authored
-