Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
flow3r firmware
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
flow3r
flow3r firmware
Commits
c232f747
Commit
c232f747
authored
1 year ago
by
dx
Browse files
Options
Downloads
Patches
Plain Diff
ci: remove mypy
After so many wasted development hours we've decided to say fuck it.
parent
a74b4742
No related branches found
Branches containing commit
No related tags found
Tags containing commit
1 merge request
!228
ci: remove mypy
Pipeline
#7357
passed
1 year ago
Stage: check
Stage: build
Stage: deploy
Changes
3
Pipelines
2
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
.gitlab-ci.yml
+0
-15
0 additions, 15 deletions
.gitlab-ci.yml
docs/badge/firmware-development.rst
+0
-8
0 additions, 8 deletions
docs/badge/firmware-development.rst
tools/mypy.sh
+0
-37
0 additions, 37 deletions
tools/mypy.sh
with
0 additions
and
60 deletions
.gitlab-ci.yml
+
0
−
15
View file @
c232f747
...
...
@@ -21,21 +21,6 @@ clang-tidy:
reports
:
codequality
:
cqual.json
mypy
:
stage
:
check
variables
:
MYPYPATH
:
python_payload/mypystubs
script
:
-
"
set
+e
+o
pipefail"
-
"
bash
tools/mypy.sh;
result=$?"
-
"
python3
tools/codequal-report.py
mypy
warnings.txt
>
cqual.json"
-
"
set
-e
-o
pipefail"
-
"
[
$result
==
0
]"
artifacts
:
when
:
always
reports
:
codequality
:
cqual.json
format
:
stage
:
check
script
:
...
...
This diff is collapsed.
Click to expand it.
docs/badge/firmware-development.rst
+
0
−
8
View file @
c232f747
...
...
@@ -70,8 +70,6 @@ For running the simulator, you'll need Python 3 with pygame and wasmer:
venv/bin/pip install https://flow3r.garden/tmp/wasmer-py311/wasmer_compiler_cranelift-1.2.0-cp311-cp311-manylinux_2_34_x86_64.whl
venv/bin/pip install https://flow3r.garden/tmp/wasmer-py311/wasmer-1.2.0-cp311-cp311-manylinux_2_34_x86_64.whl
For Python development, you're also encouraged to use mypy for typechecks. It should be available in your distribution repositories.
On macOS: the above might work.
On Windows: good luck.
...
...
@@ -93,12 +91,6 @@ As with application development, you can first check your changes using the simu
$ python3 sim/run.py
You should also run typechecks:
::
$ MYPYPATH=python_payload/mypystubs mypy python_payload/main.py
Working on C st3m code
----------------------
...
...
This diff is collapsed.
Click to expand it.
tools/mypy.sh
deleted
100755 → 0
+
0
−
37
View file @
a74b4742
#!/usr/bin/env bash
set
-e
-u
if
[
!
-f
sdkconfig.defaults
]
||
[
!
-f
recovery/sdkconfig.defaults
]
;
then
echo
>
/dev/stderr
"Run this script for the root of the repository (ie. tools/mypy.sh)."
exit
1
fi
export
MYPYPATH
=
$(
pwd
)
/python_payload/mypystubs:
$(
pwd
)
/python_payload
echo
"Checking st3m..."
_CI
=
"
${
CI
:-}
"
if
[
!
-z
"
${
_CI
}
"
]
;
then
:
>
warnings.txt
fi
failed
=
""
function
_mypy
()
{
if
[
!
-z
"
${
_CI
}
"
]
;
then
mypy
"
$1
"
--strict
--no-color-output
>>
warnings.txt
||
failed
=
true
else
mypy
"
$1
"
--strict
||
failed
=
true
fi
}
_mypy python_payload/main.py
for
f
in
python_payload/apps/
*
/flow3r.toml
;
do
app_name
=
"
$(
basename
$(
dirname
$f
))
"
echo
"Checking
${
app_name
}
..."
_mypy python_payload/apps/
${
app_name
}
done
if
[
$failed
]
;
then
echo
"Failed"
exit
1
fi
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment