Skip to content
Snippets Groups Projects
  1. Jun 05, 2019
  2. Jun 04, 2019
  3. Jun 03, 2019
  4. Jun 02, 2019
  5. May 31, 2019
  6. May 30, 2019
  7. May 29, 2019
  8. May 28, 2019
    • Damien George's avatar
      extmod/modlwip: Register TCP close-timeout callback before closing PCB. · 019dd84a
      Damien George authored
      In d5f0c87b this call to tcp_poll() was
      added to put a timeout on closing TCP sockets.  But after calling
      tcp_close() the PCB may be freed and therefore invalid, so tcp_poll() can
      not be used at that point.  As a fix this commit calls tcp_poll() before
      closing the TCP PCB.  If the PCB is subsequently closed and freed by
      tcp_close() or tcp_abort() then the PCB will not be on any active list and
      the callback will not be executed, which is the desired behaviour (the
      _lwip_tcp_close_poll() callback only needs to be called if the PCB remains
      active for longer than the timeout).
      019dd84a
    • Damien George's avatar
      extmod/modlwip: Free any incoming bufs/connections before closing PCB. · 734ada3e
      Damien George authored
      Commit 2848a613 introduced a bug where
      lwip_socket_free_incoming() accessed pcb.tcp->state after the PCB was
      closed.  The state may have changed due to that close call, or the PCB may
      be freed and therefore invalid.  This commit fixes that by calling
      lwip_socket_free_incoming() before the PCB is closed.
      734ada3e
Loading